You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by Vinayakumar B <vi...@huawei.com> on 2014/02/12 08:18:48 UTC
How patch for renamed file handled while committing?
Hi all,
If I rename a file and create a patch in SVN, it shows that old file is deleted and a new file is created with same content.
In the created patch there is no hint that original file is just renamed.
If the patch is directly applied and committed then all the checkin history for the original file will be lost.
So, the question to committers is ,
Whether such kind of renames handled explicitly though svn rename command before committing to retain the history?
Or any workaround is there to generate patch to include rename information. ?
Regards,
Vinayakumar B.,
RE: How patch for renamed file handled while committing?
Posted by Vinayakumar B <vi...@huawei.com>.
Thanks for information Suresh,
I will explicitly mention while submitting such patches.
Regards,
Vinayakumar B
-----Original Message-----
From: Suresh Srinivas [mailto:suresh@hortonworks.com]
Sent: 12 February 2014 13:00
To: hdfs-dev@hadoop.apache.org
Subject: Re: How patch for renamed file handled while committing?
It is handled using svn rename command. There are times when committers do not notice this and end up committing the patch as is. This ends up deleting the contents of renamed files, leaving behind empty files. We had to cleanup such files sometime ago.
On Tue, Feb 11, 2014 at 11:18 PM, Vinayakumar B <vi...@huawei.com>wrote:
> Hi all,
>
> If I rename a file and create a patch in SVN, it shows that old file
> is deleted and a new file is created with same content.
>
> In the created patch there is no hint that original file is just renamed.
>
> If the patch is directly applied and committed then all the checkin
> history for the original file will be lost.
>
> So, the question to committers is ,
> Whether such kind of renames handled explicitly though svn rename
> command before committing to retain the history?
> Or any workaround is there to generate patch to include rename
> information. ?
>
> Regards,
> Vinayakumar B.,
>
--
http://hortonworks.com/download/
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to which it is addressed and may contain information that is confidential, privileged and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, you are hereby notified that any printing, copying, dissemination, distribution, disclosure or forwarding of this communication is strictly prohibited. If you have received this communication in error, please contact the sender immediately and delete it from your system. Thank You.
Re: How patch for renamed file handled while committing?
Posted by Suresh Srinivas <su...@hortonworks.com>.
It is handled using svn rename command. There are times when committers do
not notice this and end up committing the patch as is. This ends up
deleting the contents of renamed files, leaving behind empty files. We had
to cleanup such files sometime ago.
On Tue, Feb 11, 2014 at 11:18 PM, Vinayakumar B <vi...@huawei.com>wrote:
> Hi all,
>
> If I rename a file and create a patch in SVN, it shows that old file is
> deleted and a new file is created with same content.
>
> In the created patch there is no hint that original file is just renamed.
>
> If the patch is directly applied and committed then all the checkin
> history for the original file will be lost.
>
> So, the question to committers is ,
> Whether such kind of renames handled explicitly though svn rename command
> before committing to retain the history?
> Or any workaround is there to generate patch to include rename
> information. ?
>
> Regards,
> Vinayakumar B.,
>
--
http://hortonworks.com/download/
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.