You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/05/16 19:29:36 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24082: chore(sqllab): Remove validation result from state
codecov[bot] commented on PR #24082:
URL: https://github.com/apache/superset/pull/24082#issuecomment-1550241354
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24082?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24082](https://app.codecov.io/gh/apache/superset/pull/24082?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d8078db) into [master](https://app.codecov.io/gh/apache/superset/commit/de96372ba7972a450c8eb68740e499db49f8cffe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (de96372) will **increase** coverage by `1.82%`.
> The diff coverage is `90.00%`.
> :exclamation: Current head d8078db differs from pull request most recent head 4591b72. Consider uploading reports for the commit 4591b72 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24082 +/- ##
==========================================
+ Coverage 66.46% 68.29% +1.82%
==========================================
Files 1942 1944 +2
Lines 75205 75170 -35
Branches 8145 8151 +6
==========================================
+ Hits 49986 51334 +1348
+ Misses 23134 21751 -1383
Partials 2085 2085
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.58% <86.20%> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24082?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://app.codecov.io/gh/apache/superset/pull/24082?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `69.12% <ø> (+2.71%)` | :arrow_up: |
| [...frontend/src/SqlLab/components/SqlEditor/index.jsx](https://app.codecov.io/gh/apache/superset/pull/24082?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci9pbmRleC5qc3g=) | `59.19% <ø> (+0.59%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://app.codecov.io/gh/apache/superset/pull/24082?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `40.93% <ø> (+2.68%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/types.ts](https://app.codecov.io/gh/apache/superset/pull/24082?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi90eXBlcy50cw==) | `57.14% <ø> (ø)` | |
| [...perset-frontend/src/hooks/apiResources/queryApi.ts](https://app.codecov.io/gh/apache/superset/pull/24082?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2hvb2tzL2FwaVJlc291cmNlcy9xdWVyeUFwaS50cw==) | `100.00% <ø> (ø)` | |
| [superset/connectors/sqla/models.py](https://app.codecov.io/gh/apache/superset/pull/24082?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.77% <ø> (+3.48%)` | :arrow_up: |
| [...rontend/src/hooks/apiResources/queryValidations.ts](https://app.codecov.io/gh/apache/superset/pull/24082?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2hvb2tzL2FwaVJlc291cmNlcy9xdWVyeVZhbGlkYXRpb25zLnRz) | `81.81% <81.81%> (ø)` | |
| [...lLab/components/AceEditorWrapper/useAnnotations.ts](https://app.codecov.io/gh/apache/superset/pull/24082?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIvdXNlQW5ub3RhdGlvbnMudHM=) | `88.23% <88.23%> (ø)` | |
| [...d/src/SqlLab/components/AceEditorWrapper/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24082?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIvaW5kZXgudHN4) | `68.75% <100.00%> (+1.30%)` | :arrow_up: |
| [superset/models/helpers.py](https://app.codecov.io/gh/apache/superset/pull/24082?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `69.73% <100.00%> (+0.52%)` | :arrow_up: |
... and [90 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24082/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org