You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/03/16 03:05:46 UTC

[GitHub] [orc] yuokada commented on a change in pull request #655: ORC-694: Update docker files for adding Java11 support

yuokada commented on a change in pull request #655:
URL: https://github.com/apache/orc/pull/655#discussion_r594829201



##########
File path: docker/README.md
##########
@@ -21,7 +21,7 @@ The scripts are:
 A base image for each OS is built using:
 
     cd docker/$os
-    docker build -t orc-$os .
+    docker build -t "orc-$os-jdk8" --build-arg jdk=8 . OR docker build -t "orc-$os-jdk11" --build-arg jdk=11 .

Review comment:
       Is this change easy to understand?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org