You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "UncertaintyDeterminesYou4ndMe (via GitHub)" <gi...@apache.org> on 2026/10/19 17:06:13 UTC
[PR] fix(desktop): read WorkHub task notices in every language [maka]
UncertaintyDeterminesYou4ndMe opened a new pull request, #6178:
URL: https://github.com/apache/maka/pull/6178
## Summary
Since dc158c054 the Host writes a WorkHub task's notice in its resolved language. The desktop looked for the English `Original worker observation:` line to read the task's JSON, so in a Chinese (or Traditional Chinese) notice it found nothing, and the notice row said only that a task ended, without its outcome (completed, failed, cancelled or rejected).
The task's JSON is the notice's last line in every language (`serde_json::to_string` in `plugins/agent/native/src/workhub/tasks/notifications.rs`), so the desktop now reads it from there.
`notices.json` is regenerated, so it also picks up the hashes of files that changed upstream without regenerating it (`packages/plugin-sdk/src/contracts.ts` and others at 6292e0674).
Refs #6078
## Verification
Run locally on macOS (Apple silicon): Biome format and lint, `node scripts/asf-license-headers.mjs check`, `node scripts/rust/notices.mjs check` (Node 24). No native code changed.
A driver script (not part of this change) ran the window against a Host built at cd3953f42 (WorkHub and the desktop's `transcript.js` are unchanged at 6292e0674) with a fake model that delegates a task. With the app in Simplified Chinese the notice's outcome read null before this change and `completed` after it; with the app in English it reads `completed` after it.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Claude Code (Claude Opus) wrote the code, the driver script and this description, under my direction and review. The commit carries a `Generated-by: Claude Code` trailer.
## Checklist
- [ ] Tests cover the change and fail without it (the script has no tests in the tree; checked by the out-of-tree driver)
- [x] Lint, format and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): read WorkHub task notices in every language [maka]
Posted by "M4n5ter (via GitHub)" <gi...@apache.org>.
M4n5ter merged PR #6178:
URL: https://github.com/apache/maka/pull/6178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org