You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@empire-db.apache.org by fr...@apache.org on 2010/08/17 10:53:48 UTC

svn commit: r986245 - /incubator/empire-db/trunk/empire-db/src/test/java/org/apache/empire/db/expr/set/DBSetExprTest.java

Author: francisdb
Date: Tue Aug 17 08:53:47 2010
New Revision: 986245

URL: http://svn.apache.org/viewvc?rev=986245&view=rev
Log:
created test case for the '' -> null and DBDatabase.EMPTY_STRING -> '' behavior

Modified:
    incubator/empire-db/trunk/empire-db/src/test/java/org/apache/empire/db/expr/set/DBSetExprTest.java

Modified: incubator/empire-db/trunk/empire-db/src/test/java/org/apache/empire/db/expr/set/DBSetExprTest.java
URL: http://svn.apache.org/viewvc/incubator/empire-db/trunk/empire-db/src/test/java/org/apache/empire/db/expr/set/DBSetExprTest.java?rev=986245&r1=986244&r2=986245&view=diff
==============================================================================
--- incubator/empire-db/trunk/empire-db/src/test/java/org/apache/empire/db/expr/set/DBSetExprTest.java (original)
+++ incubator/empire-db/trunk/empire-db/src/test/java/org/apache/empire/db/expr/set/DBSetExprTest.java Tue Aug 17 08:53:47 2010
@@ -26,10 +26,10 @@ import java.util.Set;
 
 import org.apache.empire.db.CompanyDB;
 import org.apache.empire.db.DBColumn;
+import org.apache.empire.db.DBDatabase;
 import org.apache.empire.db.DBExpr;
 import org.apache.empire.db.MockDriver;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 
 public class DBSetExprTest
@@ -62,12 +62,21 @@ public class DBSetExprTest
     }
     
     @Test
-    @Ignore("This fails for now, needs fix for non-oracle dbs")
     public void testAddSQLEmptyString()
     {
         StringBuilder builder = new StringBuilder();
         DBSetExpr setExpr = new DBSetExpr(testDB.EMPLOYEE.FIRSTNAME, "");
         setExpr.addSQL(builder, DBExpr.CTX_DEFAULT);
+        // Empire-DB by default sees '' as null
+        assertEquals("FIRSTNAME=null", builder.toString());
+    }
+    
+    @Test
+    public void testAddSQLEmptyStringConstant()
+    {
+        StringBuilder builder = new StringBuilder();
+        DBSetExpr setExpr = new DBSetExpr(testDB.EMPLOYEE.FIRSTNAME, DBDatabase.EMPTY_STRING);
+        setExpr.addSQL(builder, DBExpr.CTX_DEFAULT);
         assertEquals("FIRSTNAME=''", builder.toString());
     }