You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/08/21 01:18:53 UTC
[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei opened a new pull request #47: [YUNIKORN-815] Fix scheduler interface makefile issues.
yangwwei opened a new pull request #47:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/47
### What is this PR for?
After https://issues.apache.org/jira/browse/YUNIKORN-760, we are seeing issues updating the scheduler-interface dependency in other repos. This is because #40 has removed the GRPC generated code, but we have useful code in the core repo that still needs them, such as https://github.com/apache/incubator-yunikorn-core/tree/master/cmd.
There is another issue that has been fixed in this PR, #46 added a constant, that should go into the md file instead of the source code; the source code file is also generated. cc @HuangTing-Yao .
This PR also does more proper cleanup for `make clean`. Earlier if we have old downloaded protobuf binaries, we are skipping to download new files, which could cause problems to build files with old protobuf stuff. To avoid that, we should suggest to run `make clean` first for proper cleanup.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN/
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei commented on pull request #47: [YUNIKORN-815] Fix scheduler interface makefile issues.
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #47:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/47#issuecomment-903047737
@wilfred-s , @HuangTing-Yao pls help to review, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei commented on a change in pull request #47: [YUNIKORN-815] Fix scheduler interface makefile issues.
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #47:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/47#discussion_r694090863
##########
File path: scheduler-interface-spec.md
##########
@@ -673,8 +673,9 @@ const (
GroupAnnotation = "annotation/"
// Keys
- KeyPodName = "podName"
- KeyNamespace = "namespace"
+ KeyPodName = "podName"
+ KeyNamespace = "namespace"
+ KeyRequiredNode = "requiredNode"
Review comment:
this is not required for this PR
I've reopened https://issues.apache.org/jira/browse/YUNIKORN-810 to fix this.
##########
File path: go.mod
##########
@@ -19,10 +19,10 @@
module github.com/apache/incubator-yunikorn-scheduler-interface
-go 1.12
+go 1.15
Review comment:
Sure, will address this in a follow-up JIRA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] kingamarton commented on a change in pull request #47: [YUNIKORN-815] Fix scheduler interface makefile issues.
Posted by GitBox <gi...@apache.org>.
kingamarton commented on a change in pull request #47:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/47#discussion_r693738175
##########
File path: scheduler-interface-spec.md
##########
@@ -673,8 +673,9 @@ const (
GroupAnnotation = "annotation/"
// Keys
- KeyPodName = "podName"
- KeyNamespace = "namespace"
+ KeyPodName = "podName"
+ KeyNamespace = "namespace"
+ KeyRequiredNode = "requiredNode"
Review comment:
Is this related to build fix? If it is not I think we should address in a different Jira/PR.
##########
File path: go.mod
##########
@@ -19,10 +19,10 @@
module github.com/apache/incubator-yunikorn-scheduler-interface
-go 1.12
+go 1.15
Review comment:
I think for updating the go version is better to create a different Jira, it makes easyer to trach the changes, since this issue is a bout a build failure, not about go version upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei merged pull request #47: [YUNIKORN-815] Fix scheduler interface makefile issues.
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #47:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] HuangTing-Yao commented on pull request #47: [YUNIKORN-815] Fix scheduler interface makefile issues.
Posted by GitBox <gi...@apache.org>.
HuangTing-Yao commented on pull request #47:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/47#issuecomment-903383686
Hi @wilfred-s , I don't familiar with interface code, could you help to review this ?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org