You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/07/05 22:30:50 UTC
[jira] Created: (CASSANDRA-1249) Create ByteRandomPartitioner
Create ByteRandomPartitioner
----------------------------
Key: CASSANDRA-1249
URL: https://issues.apache.org/jira/browse/CASSANDRA-1249
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Jonathan Ellis
Assignee: Stu Hood
Priority: Minor
Fix For: 0.7
RandomPartitioner uses Strings and BigIntegers in convert to/from diskformat, which are inefficient and unnecessary
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1249) Deprecate
IPartitioner.(to|from)DiskFormat in favor of raw bytes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-1249:
--------------------------------
Attachment: 0004-Calculate-feature-flags-on-Descriptor-creation.patch
Calculate feature flags on Descriptor creation.
> Deprecate IPartitioner.(to|from)DiskFormat in favor of raw bytes
> ----------------------------------------------------------------
>
> Key: CASSANDRA-1249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1249
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-BloomFilter-fix-from-1218.patch, 0002-Test-all-legacy-snapshots-and-generate-snapshot-for-.patch, 0003-Remove-convertToDiskFormat-and-version-conditionally.patch, 0004-Calculate-feature-flags-on-Descriptor-creation.patch
>
>
> RandomPartitioner uses Strings and BigIntegers in convert to/from diskformat, which are inefficient and unnecessary
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1249) Deprecate
IPartitioner.(to|from)DiskFormat in favor of raw bytes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889159#action_12889159 ]
Hudson commented on CASSANDRA-1249:
-----------------------------------
Integrated in Cassandra #493 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/493/])
> Deprecate IPartitioner.(to|from)DiskFormat in favor of raw bytes
> ----------------------------------------------------------------
>
> Key: CASSANDRA-1249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1249
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-BloomFilter-fix-from-1218.patch, 0002-Test-all-legacy-snapshots-and-generate-snapshot-for-.patch, 0003-Remove-convertToDiskFormat-and-version-conditionally.patch, 0004-Calculate-feature-flags-on-Descriptor-creation.patch
>
>
> RandomPartitioner uses Strings and BigIntegers in convert to/from diskformat, which are inefficient and unnecessary
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1249) Deprecate
IPartitioner.(to|from)DiskFormat in favor of raw bytes
Posted by "Folke Behrens (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Folke Behrens updated CASSANDRA-1249:
-------------------------------------
Attachment: 0005-skip-subversion-subdir.patch.txt
Patch fixes LegacySSTableTest.testVersions()
http://hudson.zones.apache.org/hudson/job/Cassandra/499/testReport/org.apache.cassandra.io.sstable/LegacySSTableTest/testVersions/
> Deprecate IPartitioner.(to|from)DiskFormat in favor of raw bytes
> ----------------------------------------------------------------
>
> Key: CASSANDRA-1249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1249
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.7 beta 1
>
> Attachments: 0001-BloomFilter-fix-from-1218.patch, 0002-Test-all-legacy-snapshots-and-generate-snapshot-for-.patch, 0003-Remove-convertToDiskFormat-and-version-conditionally.patch, 0004-Calculate-feature-flags-on-Descriptor-creation.patch, 0005-skip-subversion-subdir.patch.txt
>
>
> RandomPartitioner uses Strings and BigIntegers in convert to/from diskformat, which are inefficient and unnecessary
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1249) Create ByteRandomPartitioner
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885395#action_12885395 ]
Stu Hood commented on CASSANDRA-1249:
-------------------------------------
Yea... we can deprecate to/from diskformat in partitioners, and do conditional reads based on version. I'll do this tomorrow.
> Create ByteRandomPartitioner
> ----------------------------
>
> Key: CASSANDRA-1249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1249
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.7
>
>
> RandomPartitioner uses Strings and BigIntegers in convert to/from diskformat, which are inefficient and unnecessary
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1249) Create ByteRandomPartitioner
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885360#action_12885360 ]
Stu Hood commented on CASSANDRA-1249:
-------------------------------------
Could we just kill to/from diskformat here instead?
> Create ByteRandomPartitioner
> ----------------------------
>
> Key: CASSANDRA-1249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1249
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.7
>
>
> RandomPartitioner uses Strings and BigIntegers in convert to/from diskformat, which are inefficient and unnecessary
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1249) Deprecate
IPartitioner.(to|from)DiskFormat in favor of raw bytes
Posted by "Folke Behrens (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Folke Behrens updated CASSANDRA-1249:
-------------------------------------
Attachment: (was: 0005-skip-subversion-subdir.patch.txt)
> Deprecate IPartitioner.(to|from)DiskFormat in favor of raw bytes
> ----------------------------------------------------------------
>
> Key: CASSANDRA-1249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1249
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.7 beta 1
>
> Attachments: 0001-BloomFilter-fix-from-1218.patch, 0002-Test-all-legacy-snapshots-and-generate-snapshot-for-.patch, 0003-Remove-convertToDiskFormat-and-version-conditionally.patch, 0004-Calculate-feature-flags-on-Descriptor-creation.patch
>
>
> RandomPartitioner uses Strings and BigIntegers in convert to/from diskformat, which are inefficient and unnecessary
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1249) Deprecate
IPartitioner.(to|from)DiskFormat in favor of raw bytes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886843#action_12886843 ]
Jonathan Ellis commented on CASSANDRA-1249:
-------------------------------------------
doing string comparisons [on the version] for every key we read seems like a bad idea for performance. that's the nice thing about the current code; you instantiate the right class once, and it never has to do any if-statements.
> Deprecate IPartitioner.(to|from)DiskFormat in favor of raw bytes
> ----------------------------------------------------------------
>
> Key: CASSANDRA-1249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1249
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-BloomFilter-fix-from-1218.patch, 0002-Test-all-legacy-snapshots-and-generate-snapshot-for-.patch, 0003-Remove-convertToDiskFormat-and-version-conditionally.patch
>
>
> RandomPartitioner uses Strings and BigIntegers in convert to/from diskformat, which are inefficient and unnecessary
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1249) Deprecate
IPartitioner.(to|from)DiskFormat in favor of raw bytes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-1249:
--------------------------------
Attachment: 0001-BloomFilter-fix-from-1218.patch
0002-Test-all-legacy-snapshots-and-generate-snapshot-for-.patch
0003-Remove-convertToDiskFormat-and-version-conditionally.patch
0001 Adds the bloomfilter fix from 1218: I've closed that ticket.
0002 Snapshots the current SSTable version, and makes LegacySSTableTest check all snapshotted versions
0003 Removes convertTo and conditionally uses convertFrom inside SSTableReader.decodeKey
Ready for review.
> Deprecate IPartitioner.(to|from)DiskFormat in favor of raw bytes
> ----------------------------------------------------------------
>
> Key: CASSANDRA-1249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1249
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-BloomFilter-fix-from-1218.patch, 0002-Test-all-legacy-snapshots-and-generate-snapshot-for-.patch, 0003-Remove-convertToDiskFormat-and-version-conditionally.patch
>
>
> RandomPartitioner uses Strings and BigIntegers in convert to/from diskformat, which are inefficient and unnecessary
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1249) Deprecate
IPartitioner.(to|from)DiskFormat in favor of raw bytes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892141#action_12892141 ]
Stu Hood commented on CASSANDRA-1249:
-------------------------------------
See CASSANDRA-1309
> Deprecate IPartitioner.(to|from)DiskFormat in favor of raw bytes
> ----------------------------------------------------------------
>
> Key: CASSANDRA-1249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1249
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.7 beta 1
>
> Attachments: 0001-BloomFilter-fix-from-1218.patch, 0002-Test-all-legacy-snapshots-and-generate-snapshot-for-.patch, 0003-Remove-convertToDiskFormat-and-version-conditionally.patch, 0004-Calculate-feature-flags-on-Descriptor-creation.patch, 0005-skip-subversion-subdir.patch.txt
>
>
> RandomPartitioner uses Strings and BigIntegers in convert to/from diskformat, which are inefficient and unnecessary
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1249) Create ByteRandomPartitioner
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885363#action_12885363 ]
Jonathan Ellis commented on CASSANDRA-1249:
-------------------------------------------
can we do that and still support reading 0.6 data?
> Create ByteRandomPartitioner
> ----------------------------
>
> Key: CASSANDRA-1249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1249
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.7
>
>
> RandomPartitioner uses Strings and BigIntegers in convert to/from diskformat, which are inefficient and unnecessary
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-1249) Create
ByteRandomPartitioner
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885395#action_12885395 ]
Stu Hood edited comment on CASSANDRA-1249 at 7/6/10 12:27 PM:
--------------------------------------------------------------
Yea... we can deprecate to/from diskformat in partitioners, and do conditional reads based on version. I'll do this EDIT: before 0.7.
was (Author: stuhood):
Yea... we can deprecate to/from diskformat in partitioners, and do conditional reads based on version. I'll do this tomorrow.
> Create ByteRandomPartitioner
> ----------------------------
>
> Key: CASSANDRA-1249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1249
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.7
>
>
> RandomPartitioner uses Strings and BigIntegers in convert to/from diskformat, which are inefficient and unnecessary
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1249) Deprecate
IPartitioner.(to|from)DiskFormat in favor of raw bytes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-1249:
--------------------------------
Summary: Deprecate IPartitioner.(to|from)DiskFormat in favor of raw bytes (was: Create ByteRandomPartitioner)
> Deprecate IPartitioner.(to|from)DiskFormat in favor of raw bytes
> ----------------------------------------------------------------
>
> Key: CASSANDRA-1249
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1249
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.7
>
>
> RandomPartitioner uses Strings and BigIntegers in convert to/from diskformat, which are inefficient and unnecessary
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.