You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@solr.apache.org by Walter Underwood <wu...@wunderwood.org> on 2024/08/27 18:40:34 UTC
Unfinished Business: Fuzzy in edismax
I’m retired and not working on Solr all the time, but there are two things I didn’t finish that should be picked up. I’m not going to do these, I’ve got plenty of retirement stuff to do.
The first is SOLR-629, probably the oldest open feature request and a good first project for someone. This adds support for fuzzy search to the edismax query parser. The external impact is tiny, the qf config just says “title~” instead of “title”.
The most recent patch is for 4.x. It doesn’t apply 100% to the current code (more like 50%), but it should be fairly easy to figure out the needed mods.
This should be a nice project for a first-time contributor, because it is localized to the edismax parse. That is spread out a bit, but not too bad. Besides, who gets to work on a three-digit Jira issue?
Two notes:
1. You’ll get the urge to rewrite the whole damned edismax config parser with a real parser generator. Resist that and just make the change.
2. It isn’t possible to have a higher boost for an exact match and a lower boost for a fuzzy match because it only handles one config spec per field name. And it doesn’t throw an error for the second time, either. It really should handle “title^4 title~^2”. The workaround is to make a copy of the title field. Maybe that should be a separate Jira issue?
wunder
Walter Underwood
wunder@wunderwood.org
http://observer.wunderwood.org/ (my blog)
Re: Unfinished Business: Fuzzy in edismax
Posted by Walter Underwood <wu...@wunderwood.org>.
Thank you, I should have done that.
I will make a new Jira issue for the fast IDF change, though that will wait until we are back from Provence. Just retired for a few months and enjoying it!
wunder
Walter Underwood
https://observer.wunderwood.org/
> On Sep 9, 2024, at 2:15 PM, Jason Gerlowski <ge...@gmail.com> wrote:
>
> Hi Walter,
>
> Congrats on the retirement (if it's "new") and enjoy!
>
> Thanks for doing an explicit "handoff" of context here; I've copied
> your notes onto the JIRA ticket, so they don't get buried by time.
>
> Best,
>
> Jason
>
>> On Tue, Aug 27, 2024 at 2:44 PM Walter Underwood <wu...@wunderwood.org> wrote:
>>
>> Oops. https://issues.apache.org/jira/browse/SOLR-629 —wunder
>>
>>>> On Aug 27, 2024, at 11:40 AM, Walter Underwood <wu...@wunderwood.org> wrote:
>>>
>>> I’m retired and not working on Solr all the time, but there are two things I didn’t finish that should be picked up. I’m not going to do these, I’ve got plenty of retirement stuff to do.
>>>
>>> The first is SOLR-629, probably the oldest open feature request and a good first project for someone. This adds support for fuzzy search to the edismax query parser. The external impact is tiny, the qf config just says “title~” instead of “title”.
>>>
>>> The most recent patch is for 4.x. It doesn’t apply 100% to the current code (more like 50%), but it should be fairly easy to figure out the needed mods.
>>>
>>> This should be a nice project for a first-time contributor, because it is localized to the edismax parse. That is spread out a bit, but not too bad. Besides, who gets to work on a three-digit Jira issue?
>>>
>>> Two notes:
>>>
>>> 1. You’ll get the urge to rewrite the whole damned edismax config parser with a real parser generator. Resist that and just make the change.
>>> 2. It isn’t possible to have a higher boost for an exact match and a lower boost for a fuzzy match because it only handles one config spec per field name. And it doesn’t throw an error for the second time, either. It really should handle “title^4 title~^2”. The workaround is to make a copy of the title field. Maybe that should be a separate Jira issue?
>>>
>>> wunder
>>> Walter Underwood
>>> wunder@wunderwood.org
>>> http://observer.wunderwood.org/ (my blog)
>>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
> For additional commands, e-mail: dev-help@solr.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org
Re: Unfinished Business: Fuzzy in edismax
Posted by Jason Gerlowski <ge...@gmail.com>.
Hi Walter,
Congrats on the retirement (if it's "new") and enjoy!
Thanks for doing an explicit "handoff" of context here; I've copied
your notes onto the JIRA ticket, so they don't get buried by time.
Best,
Jason
On Tue, Aug 27, 2024 at 2:44 PM Walter Underwood <wu...@wunderwood.org> wrote:
>
> Oops. https://issues.apache.org/jira/browse/SOLR-629 —wunder
>
> > On Aug 27, 2024, at 11:40 AM, Walter Underwood <wu...@wunderwood.org> wrote:
> >
> > I’m retired and not working on Solr all the time, but there are two things I didn’t finish that should be picked up. I’m not going to do these, I’ve got plenty of retirement stuff to do.
> >
> > The first is SOLR-629, probably the oldest open feature request and a good first project for someone. This adds support for fuzzy search to the edismax query parser. The external impact is tiny, the qf config just says “title~” instead of “title”.
> >
> > The most recent patch is for 4.x. It doesn’t apply 100% to the current code (more like 50%), but it should be fairly easy to figure out the needed mods.
> >
> > This should be a nice project for a first-time contributor, because it is localized to the edismax parse. That is spread out a bit, but not too bad. Besides, who gets to work on a three-digit Jira issue?
> >
> > Two notes:
> >
> > 1. You’ll get the urge to rewrite the whole damned edismax config parser with a real parser generator. Resist that and just make the change.
> > 2. It isn’t possible to have a higher boost for an exact match and a lower boost for a fuzzy match because it only handles one config spec per field name. And it doesn’t throw an error for the second time, either. It really should handle “title^4 title~^2”. The workaround is to make a copy of the title field. Maybe that should be a separate Jira issue?
> >
> > wunder
> > Walter Underwood
> > wunder@wunderwood.org
> > http://observer.wunderwood.org/ (my blog)
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org
Re: Unfinished Business: Fuzzy in edismax
Posted by Walter Underwood <wu...@wunderwood.org>.
Oops. https://issues.apache.org/jira/browse/SOLR-629 —wunder
> On Aug 27, 2024, at 11:40 AM, Walter Underwood <wu...@wunderwood.org> wrote:
>
> I’m retired and not working on Solr all the time, but there are two things I didn’t finish that should be picked up. I’m not going to do these, I’ve got plenty of retirement stuff to do.
>
> The first is SOLR-629, probably the oldest open feature request and a good first project for someone. This adds support for fuzzy search to the edismax query parser. The external impact is tiny, the qf config just says “title~” instead of “title”.
>
> The most recent patch is for 4.x. It doesn’t apply 100% to the current code (more like 50%), but it should be fairly easy to figure out the needed mods.
>
> This should be a nice project for a first-time contributor, because it is localized to the edismax parse. That is spread out a bit, but not too bad. Besides, who gets to work on a three-digit Jira issue?
>
> Two notes:
>
> 1. You’ll get the urge to rewrite the whole damned edismax config parser with a real parser generator. Resist that and just make the change.
> 2. It isn’t possible to have a higher boost for an exact match and a lower boost for a fuzzy match because it only handles one config spec per field name. And it doesn’t throw an error for the second time, either. It really should handle “title^4 title~^2”. The workaround is to make a copy of the title field. Maybe that should be a separate Jira issue?
>
> wunder
> Walter Underwood
> wunder@wunderwood.org
> http://observer.wunderwood.org/ (my blog)
>