You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/03/24 18:35:47 UTC
[GitHub] [servicecomb-java-chassis] Shoothzj opened a new pull request #2748: make archetype springboot version consistent with project
Shoothzj opened a new pull request #2748:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2748
## motivation
make archetype springboot version consistent with project
## changes
update springboot version from `2.1.2.RELEASE` to `2.5.6`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2748: [SCB-2430]make archetype springboot version consistent with project
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2748:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2748#discussion_r834878975
##########
File path: archetypes/business-service-springmvc/src/main/resources/archetype-resources/pom.xml
##########
@@ -26,7 +26,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <java-chassis.version>2.1.2.RELEASE</java-chassis.version>
+ <java-chassis.version>2.5.6</java-chassis.version>
Review comment:
Maybe you need update java chassis version in this PR too. Because you can't change spring boot version without change java chassis version. Java chassis 2.0.0. may not work with spring boot 2.5.3. Use Java Chassis 2.6.0 to work with spring boot 2.5.3.
However, this spring-boot.version only take effect with maven spring boot plugin, the project spring boot version is controlled by dependency management, will not cause any problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2748: [SCB-2430]make archetype springboot version consistent with project
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2748:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2748#discussion_r834878975
##########
File path: archetypes/business-service-springmvc/src/main/resources/archetype-resources/pom.xml
##########
@@ -26,7 +26,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <java-chassis.version>2.1.2.RELEASE</java-chassis.version>
+ <java-chassis.version>2.5.6</java-chassis.version>
Review comment:
Maybe you need update java chassis version in this PR too. Because you can't change spring boot version without change java chassis version. Java chassis 2.0.0. may not work with spring boot 2.5.3. Use Java Chassis 2.6.0 to work with spring boot 2.5.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2748: [SCB-2430]make archetype springboot version consistent with project
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2748:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2748: [SCB-2430]make archetype springboot version consistent with project
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2748:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2748#discussion_r834878975
##########
File path: archetypes/business-service-springmvc/src/main/resources/archetype-resources/pom.xml
##########
@@ -26,7 +26,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <java-chassis.version>2.1.2.RELEASE</java-chassis.version>
+ <java-chassis.version>2.5.6</java-chassis.version>
Review comment:
Maybe you need update java chassis version in this PR too. Because you can't change spring boot version without change java chassis version. Java chassis 2.0.0. may not work with spring boot 2.5.3. Use Java Chassis 2.6.0 to work with spring boot 2.5.3.
However, this spring-boot.version only take effect with maven spring boot plugin, will not cause any problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj commented on a change in pull request #2748: [SCB-2430]make archetype springboot version consistent with project
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on a change in pull request #2748:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2748#discussion_r834876075
##########
File path: archetypes/business-service-springmvc/src/main/resources/archetype-resources/pom.xml
##########
@@ -26,7 +26,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <java-chassis.version>2.1.2.RELEASE</java-chassis.version>
+ <java-chassis.version>2.5.6</java-chassis.version>
Review comment:
@liubao68 sorry for my mistake, I may need coffee that time. I will revert this change, and fix java-chassis version in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2748: make archetype springboot version consistent with project
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2748:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2748#discussion_r834872108
##########
File path: archetypes/business-service-spring-boot2-starter/src/main/resources/archetype-resources/pom.xml
##########
@@ -28,7 +28,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<!-- this version is used for archetype, do not need to change when release a new version -->
<java-chassis.version>2.0.0</java-chassis.version>
- <springboot.version>2.1.2.RELEASE</springboot.version>
+ <springboot.version>2.5.6</springboot.version>
Review comment:
Should change java-chassis.verion and springboot.version together. java chassis 2.0.0 may not work with spring boot 2.5.6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2748: make archetype springboot version consistent with project
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2748:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2748#discussion_r834872422
##########
File path: archetypes/business-service-springmvc/src/main/resources/archetype-resources/pom.xml
##########
@@ -26,7 +26,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <java-chassis.version>2.1.2.RELEASE</java-chassis.version>
+ <java-chassis.version>2.5.6</java-chassis.version>
Review comment:
This is java chassis version. Maybe an old bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2748: make archetype springboot version consistent with project
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2748:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2748#issuecomment-1077950665
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2748?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2748](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2748?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34e01d2) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/09feec0f964367364a855e795be07377046563f4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09feec0) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 34e01d2 differs from pull request most recent head 794d089. Consider uploading reports for the commit 794d089 to get more accurate results
```diff
@@ Coverage Diff @@
## master #2748 +/- ##
============================================
+ Coverage 77.25% 77.26% +0.01%
Complexity 1417 1417
============================================
Files 1614 1614
Lines 43234 43234
Branches 3665 3665
============================================
+ Hits 33400 33405 +5
+ Misses 8300 8296 -4
+ Partials 1534 1533 -1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2748?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/servicecomb/foundation/common/net/NetUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2748/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9OZXRVdGlscy5qYXZh) | `62.99% <0.00%> (-1.58%)` | :arrow_down: |
| [...mb/config/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2748/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvblNvdXJjZUltcGwuamF2YQ==) | `9.78% <0.00%> (-1.09%)` | :arrow_down: |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2748/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `71.04% <0.00%> (+1.14%)` | :arrow_up: |
| [...mb/serviceregistry/client/http/RestClientUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2748/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1Jlc3RDbGllbnRVdGlsLmphdmE=) | `80.55% <0.00%> (+1.85%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2748?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2748?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [09feec0...794d089](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2748?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj commented on a change in pull request #2748: [SCB-2430]make archetype springboot version consistent with project
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on a change in pull request #2748:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2748#discussion_r834882284
##########
File path: archetypes/business-service-springmvc/src/main/resources/archetype-resources/pom.xml
##########
@@ -26,7 +26,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <java-chassis.version>2.1.2.RELEASE</java-chassis.version>
+ <java-chassis.version>2.5.6</java-chassis.version>
Review comment:
make sense, I will fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org