You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/08/12 09:43:50 UTC
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #701: consul service discovery
AlexStocks commented on a change in pull request #701:
URL: https://github.com/apache/dubbo-go/pull/701#discussion_r469138048
##########
File path: registry/event/event_publishing_service_discovery.go
##########
@@ -34,6 +39,7 @@ import (
// Publish some event about service discovery
type EventPublishingServiceDiscovery struct {
serviceDiscovery registry.ServiceDiscovery
+ once sync.Once
Review comment:
u add this var just for `epsd.serviceDiscovery.Initialize`. so u may need to change its name which is not so common, IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org