You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/18 22:59:25 UTC
[jira] [Commented] (MINIFI-18) RunMiNiFi starts notifiers each time
./minifi.sh gets run
[ https://issues.apache.org/jira/browse/MINIFI-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246521#comment-15246521 ]
ASF GitHub Bot commented on MINIFI-18:
--------------------------------------
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi/pull/11
MINIFI-18 Moving initialization of configuration notifier/listener from constructor
MINIFI-18 Moving initialization of configuration notifier/listener from constructor such that it is only performed when starting an instance.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/nifi-minifi MINIFI-18
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi/pull/11.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11
----
commit 2cd26322e5c580a03be6b812c51b05352bcd2ffd
Author: Aldrin Piri <al...@apache.org>
Date: 2016-04-18T20:57:37Z
MINIFI-18 Moving initialization of configuration notifier/listener from
constructor such that it is only performed when starting an instance.
----
> RunMiNiFi starts notifiers each time ./minifi.sh gets run
> ---------------------------------------------------------
>
> Key: MINIFI-18
> URL: https://issues.apache.org/jira/browse/MINIFI-18
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Reporter: Joseph Percivall
> Assignee: Aldrin Piri
>
> this line: https://github.com/apache/nifi-minifi/blob/3a967be7a6fa6dbaceeff28f4af8c7ce05b77f2c/minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/RunMiNiFi.java#L202-L202
> calls notifiers init every time:https://github.com/apache/nifi-minifi/blob/3a967be7a6fa6dbaceeff28f4af8c7ce05b77f2c/minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/RunMiNiFi.java#L151-L151
> so asking for "minifi.sh status" causes the notifiers to be re initialized and started (so the rest config will attempt to bind to the address again):
> https://github.com/apache/nifi-minifi/blob/3a967be7a6fa6dbaceeff28f4af8c7ce05b77f2c/minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/RunMiNiFi.java#L1299-L1299
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)