You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2014/03/17 13:11:46 UTC

[jira] [Resolved] (WICKET-4027) Consider dropping MockPageManager and use mock IPageStore instead

     [ https://issues.apache.org/jira/browse/WICKET-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-4027.
-------------------------------------

    Resolution: Later

The problems will be addressed once there is a real need.
It seems for now the mocked page manager does its job.

> Consider dropping MockPageManager and use mock IPageStore instead
> -----------------------------------------------------------------
>
>                 Key: WICKET-4027
>                 URL: https://issues.apache.org/jira/browse/WICKET-4027
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Martin Grigorov
>         Attachments: WICKET-4027-2.patch
>
>
> Currently WicketTester setups custom IPageManager (MockPageManager) which has several problems:
> 1) it saves stateless pages - touchPage(statelessPage) shouldn't be stored
> 2) it calls #detach() for all pages ever stored in the map. it should call it only on the pages stored in the last request.
> If we fix these problems then we are going to reimplement the default IPageManager (StorePageManager). So I suggest to drop MockPageManager and setup inmemory IPageStore behind it instead. This way we can test PageStoreBehavior as well.



--
This message was sent by Atlassian JIRA
(v6.2#6252)