You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/10 19:12:06 UTC

[GitHub] [incubator-mxnet] szha commented on issue #18886: bug of NDarray.reshape

szha commented on issue #18886:
URL: https://github.com/apache/incubator-mxnet/issues/18886#issuecomment-671536474


   @cs8105 congrats that you have found mxnet's built-in way of creating memory leaks🤦‍♂️
   
   Joke aside, I think what we need here is a check for consistent size. the logic for ndarray can be found here:
   https://github.com/apache/incubator-mxnet/blob/cc287a0fc2de030c5cbb826092cd1863c72931aa/python/mxnet/ndarray/ndarray.py#L1501-L1520
   
   Would you like to open a PR to add a check that makes sure the size is consistent before and after the reshape, and raise ValueError otherwise? The process is described at https://cwiki.apache.org/confluence/display/MXNET/Git+Setup+and+Workflow


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org