You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "guan404ming (via GitHub)" <gi...@apache.org> on 2025/06/09 12:43:16 UTC
[PR] Add translation issue template and pre-commit [airflow]
guan404ming opened a new pull request, #51531:
URL: https://github.com/apache/airflow/pull/51531
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
## Related PR
- https://github.com/apache/airflow/pull/51292
## Why
When a new language is added to Airflow, reviewers need to check the translations before the language is fully accepted. If all translations are included in a single pull request, it becomes difficult to track what has been reviewed. Creating a meta issue to track translation progress will make the process much clearer and easier to manage.
## How
- add an issue template to help track translation progress.
- use pre-commit to automatically update a checklist whenever new translations are added to the default language JSON file.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add translation issue template and pre-commit [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #51531:
URL: https://github.com/apache/airflow/pull/51531#issuecomment-2956527635
> But I am not **strongly** opposed - I just wonder how it fits in the "translation" process and how future translators will approach their tasks.
>
> The way how I imagine it is that they will do: `uv run ./check_translation_completness.py --language NEW_LANGUAGE --add-missing`.
>
> This will generate all the files with TODO: and we would expect the PR to only be merged where all TODO: are completed and things translated - the PR can be opened and iterated through multiple times, but It adds very little value if new language is "partially" added only. I can imagine that we should only accept new languages, when the person (or people) doing translation will show that they are able to do the job - and complete all currently needed translations rather than allow them to submit partial translations. I would very much prefer such translation to be a complete PR with all entries translated - because otherwise the person can disappear or burn out before all of it is done, which would mean we will have to remove it.
>
> So ... if that will be the process, then TODOs: in generated files indicate things to be done - and we could even improve the check_translation_completness.py script to count number of entries and number of TODO: left - to show progress in percentage, that the user will be able to run and see the progress. This is IMHO a bit better than having and issue that you need to manually update.
It does make sense to me to make it a automated-todo gen instead of a issue need our manual update. Let me mark it as draft for now. I would re-open it if I have new idea about it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add translation issue template and pre-commit [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #51531:
URL: https://github.com/apache/airflow/pull/51531#issuecomment-2956181190
For example https://github.com/apache/airflow/pull/51537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add translation issue template and pre-commit [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #51531:
URL: https://github.com/apache/airflow/pull/51531#issuecomment-2956045669
But I am not **strongly** opposed - I just wonder how it fits in the "translation" process and how future translators will approach their tasks.
The way how I imagine it is that they will do: ``uv run ./check_translation_completness.py --language NEW_LANGUAGE --add-missing``.
This will generate all the files with TODO: and we would expect the PR to only be merged where all TODO: are completed and things translated - the PR can be opened and iterated through multiple times, but It adds very little value if new language is "partially" added only. I can imagine that we should only accept new languages, when the person (or people) doing translation will show that they are able to do the job - and complete all currently needed translations rather than allow them to submit partial translations. I would very much prefer such translation to be a complete PR with all entries translated - because otherwise the person can disappear or burn out before all of it is done, which would mean we will have to remove it.
So ... if that will be the process, then TODOs: in generated files indicate things to be done - and we could even improve the check_translation_completness.py script to count number of entries and number of TODO: left - to show progress in percentage, that the user will be able to run and see the progress. This is IMHO a bit better than having and issue that you need to manually update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add translation issue template and pre-commit [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #51531:
URL: https://github.com/apache/airflow/pull/51531#issuecomment-2955954805
Thanks for your feedback. The reason for creating an "meta issue" is to better track translation progress when adding new lang. As files increase in the future, it gets hard to manage all translations otherwise. A checklist helps everyone see what’s done and what’s pending to prevent conflict. For small fixes, direct PRs are fine, but for bigger translation efforts like adding a new lang, a central issue makes coordination clearer in my opinion.
Let me know if you have other suggestions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add translation issue template and pre-commit [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #51531:
URL: https://github.com/apache/airflow/pull/51531#issuecomment-2956020406
We are big fans of not having to much "boilerplate" -> for example we do not want Issue, when PR is enough. I am also not sure - same as @eladkal, if that one adds much value. We already have the script of minr that checks and produces list of missing files and missing translation in files and it can be run with `--language` flag to limit the check to only one language. And basically it produces the detailed "status" of translation. I am not sure if we need another issue to track it separately - sounds like "double accounting".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add translation issue template and pre-commit [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming closed pull request #51531: Add translation issue template and pre-commit
URL: https://github.com/apache/airflow/pull/51531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org