You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jiangxb1987 <gi...@git.apache.org> on 2017/05/25 21:49:31 UTC

[GitHub] spark pull request #18078: [SPARK-10643] [Core] Make spark-submit download r...

Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18078#discussion_r118593252
  
    --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
    @@ -535,7 +538,7 @@ class SparkSubmitSuite
     
       test("resolves command line argument paths correctly") {
         val jars = "/jar1,/jar2"                 // --jars
    -    val files = "hdfs:/file1,file2"          // --files
    +    val files = "local:/file1,file2"          // --files
    --- End diff --
    
    It is kinda difficult to test download file from hdfs now, but we should cover this scene in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org