You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ilya Borisov (JIRA)" <ji...@apache.org> on 2018/09/13 07:42:00 UTC
[jira] [Updated] (IGNITE-9569) Web console: use $inject for DI
instead of arrays
[ https://issues.apache.org/jira/browse/IGNITE-9569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Borisov updated IGNITE-9569:
---------------------------------
Description:
To do:
1. Remove provider registration by array spread, like this:
{code:java}
.service(...serviceArray){code}
Instead, use the canonical AngularJS approach:
{code:java}
.service('SeriveName', Service){code}
2. Do not use array Di syntax for exported symbols:
{code:java}
export ['IgniteVersion', 'Confirm', function directive (version, confirm){}]{code}
Instead, use $inject property:
{code:java}
export function directive(version, confirm) {}
directive.$inject = ['IgniteVersion', 'Confirm']{code}
Motivation:
The changes above will make older providers accessible to TypeScript, which in turn will allow to increase type coverage.
was:
To do:
1. Remove provider registration by array spread, like this:
{code:java}
.service(...serviceArray){code}
Instead, use the canonical AngularJS approach:
{code:java}
.service('SeriveName', Service){code}
2. Do not use array Di syntax for exported symbols:
{code:java}
export ['IgniteVersion', 'Confirm', function directive (version, confirm){}]{code}
Instead, use $inject property:
{code:java}
export function directive(version, confirm) {}
directive.$inject = ['IgniteVersion', 'Confirm']{code}
Motivation:
The changes above will make older providers accessible to TypeScript, which in turn will allow to increase type coverage.
> Web console: use $inject for DI instead of arrays
> -------------------------------------------------
>
> Key: IGNITE-9569
> URL: https://issues.apache.org/jira/browse/IGNITE-9569
> Project: Ignite
> Issue Type: Improvement
> Components: wizards
> Reporter: Ilya Borisov
> Assignee: Ilya Borisov
> Priority: Minor
>
> To do:
> 1. Remove provider registration by array spread, like this:
> {code:java}
> .service(...serviceArray){code}
> Instead, use the canonical AngularJS approach:
> {code:java}
> .service('SeriveName', Service){code}
> 2. Do not use array Di syntax for exported symbols:
> {code:java}
> export ['IgniteVersion', 'Confirm', function directive (version, confirm){}]{code}
> Instead, use $inject property:
> {code:java}
> export function directive(version, confirm) {}
> directive.$inject = ['IgniteVersion', 'Confirm']{code}
>
> Motivation:
> The changes above will make older providers accessible to TypeScript, which in turn will allow to increase type coverage.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)