You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/06/02 22:44:10 UTC

[GitHub] [trafficcontrol] rob05c opened a new pull request #5908: Fix t3c parent.config gen for EDGE/MID+ Types

rob05c opened a new pull request #5908:
URL: https://github.com/apache/trafficcontrol/pull/5908


   Fixed t3c to generate topology parents correctly for parents with the Type MID+ or EDGE+ versus just the literal. Naming cache types to not be exactly 'EDGE' or 'MID' is still discouraged and not guaranteed to work, but it's unfortutely somewhat common, so this fixes it in one particular case.
   
   Includes tests.
   Includes changelog.
   No docs, no interface change.
   
   - [x] This PR is not related to any other Issue
   
   Labelling "bug" even though the behavior it "fixes" isn't guaranteed, because it's a non-uncommon user behavior that it does fix. 
   
   Long-term, cache config generation for Topologies needs to entirely remove "Edge" and "Mid" terminology, though it will still need some way to distinguish Caches from non-cache Servers (unless TO is made more Normal).
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops ORT
   
   ## What is the best way to verify this PR?
   Run lib/go-atscfg unit tests. Create a Topology with a parent server of type "MID_FOO," assign to a DS, generate config for an child server, verify the MID_FOO type parent is in the child's parent.config.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   - 
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] rawlinp merged pull request #5908: Fix t3c parent.config gen for EDGE/MID+ Types

Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #5908:
URL: https://github.com/apache/trafficcontrol/pull/5908


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] rawlinp merged pull request #5908: Fix t3c parent.config gen for EDGE/MID+ Types

Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #5908:
URL: https://github.com/apache/trafficcontrol/pull/5908


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org