You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Malcolm Rowe <ma...@farside.org.uk> on 2006/10/18 17:41:47 UTC
Re: svn commit: r22019 - trunk/subversion/tests/cmdline
Hey Lieven,
On Wed, Oct 18, 2006 at 09:51:09AM -0700, lgo@tigris.org wrote:
> ==============================================================================
> --- trunk/subversion/tests/cmdline/authz_tests.py (original)
> +++ trunk/subversion/tests/cmdline/authz_tests.py Wed Oct 18 09:51:09 2006
> @@ -43,7 +43,7 @@
> fp.write("password-db = passwd\n")
> fp.close()
>
> -def write_authz_file(sbox, rules):
> +def write_authz_file(sbox, rules, section=None):
> """Write an authz file to SBOX, appropriate for the RA method used,
> with authorizations rules RULES, mapping paths to strings containing
> the rules."""
Could you update the doc comment to describe SECTION?
> @@ -666,6 +712,7 @@
> authz_log_and_tracing_test,
> authz_checkout_and_update_test,
> authz_partial_export_test,
> + authz_aliases
We normally leave a trailing comma so that the next test doesn't have to
modify the previous line.
Regards,
Malcolm
Re: svn commit: r22019 - trunk/subversion/tests/cmdline
Posted by Paul Burba <pa...@softlanding.com>.
Lieven Govaerts <lg...@mobsol.be> wrote on 10/18/2006 02:40:03 PM:
> Fixed in r22022.
>
> Lieven.
Hi Lieven,
There is another problem with r22022, your new authz_aliases test fails
over svn://.
I fixed it in r22106.
Paul B.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r22019 - trunk/subversion/tests/cmdline
Posted by Lieven Govaerts <lg...@mobsol.be>.
Fixed in r22022.
Lieven.
Malcolm Rowe wrote:
> Hey Lieven,
>
> On Wed, Oct 18, 2006 at 09:51:09AM -0700, lgo@tigris.org wrote:
>> ==============================================================================
>> --- trunk/subversion/tests/cmdline/authz_tests.py (original)
>> +++ trunk/subversion/tests/cmdline/authz_tests.py Wed Oct 18 09:51:09 2006
>> @@ -43,7 +43,7 @@
>> fp.write("password-db = passwd\n")
>> fp.close()
>>
>> -def write_authz_file(sbox, rules):
>> +def write_authz_file(sbox, rules, section=None):
>> """Write an authz file to SBOX, appropriate for the RA method used,
>> with authorizations rules RULES, mapping paths to strings containing
>> the rules."""
>
> Could you update the doc comment to describe SECTION?
>
>> @@ -666,6 +712,7 @@
>> authz_log_and_tracing_test,
>> authz_checkout_and_update_test,
>> authz_partial_export_test,
>> + authz_aliases
>
> We normally leave a trailing comma so that the next test doesn't have to
> modify the previous line.
>
> Regards,
> Malcolm
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org