You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jason Gerlowski (JIRA)" <ji...@apache.org> on 2016/03/13 04:34:33 UTC
[jira] [Updated] (SOLR-8836) /update should return BAD REQUEST when
invalid JSON provided
[ https://issues.apache.org/jira/browse/SOLR-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Gerlowski updated SOLR-8836:
----------------------------------
Attachment: SOLR-8836.patch
A simple patch demonstrating a fix for the issue. With this fix, /update answers invalid JSON with the response:
{code}
[~/c/s/l/solr] $ curl -i -l -k -X POST -H 'Content-Type: application/json' 'http://localhost:7574/solr/gettingstarted/update' --data-binary '}{'
HTTP/1.1 400 Bad Request
{"responseHeader":{"status":400,"QTime":11},"error":{"metadata":["error-class","org.apache.solr.common.SolrException","root-error-class","org.noggit.JSONParser$ParseException"],"msg":"org.noggit.JSONParser$ParseException: JSON Parse Error: char=},position=0 BEFORE='}' AFTER='{'","code":400}}
{code}
This fixes the status code, but the response body is a little odd. I'm not quite sure where the "metadata", "error-class", "root-error-class" nesting comes from. Still some details of Solr's error reporting that I'm brushing up on; bit of a work-in-progress.
> /update should return BAD REQUEST when invalid JSON provided
> ------------------------------------------------------------
>
> Key: SOLR-8836
> URL: https://issues.apache.org/jira/browse/SOLR-8836
> Project: Solr
> Issue Type: Bug
> Affects Versions: master
> Reporter: Jason Gerlowski
> Priority: Trivial
> Fix For: master
>
> Attachments: SOLR-8836.patch
>
>
> When a user provides invalid JSON to the /update endpoint, the request fails with a 500 (INTERNAL SERVER ERROR). If the user looks at the response body, they'll see a message indicating that the provided JSON was invalid. However, going from the status code alone, the failure is indistinguishable from a true server-error. This is a bit misleading. It would be nice if Solr instead returned a 400 (BAD REQUEST) status code when it detects invalid arguments.
> Reproduction Steps:
> 1.) bin/solr start -e cloud -noprompt
> 2.) curl -i -l -k -X POST -H 'Content-Type: application/json' 'http://localhost:8983/solr/gettingstarted/update' --data-binary '}{'
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org