You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/02/01 18:50:09 UTC

[GitHub] [nifi] mcgilman commented on a change in pull request #5712: NIFI-9628: Added a uiOnly flag when requesting Controller Service det…

mcgilman commented on a change in pull request #5712:
URL: https://github.com/apache/nifi/pull/5712#discussion_r796871356



##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-process-group-configuration.js
##########
@@ -348,7 +354,10 @@
         var parameterContexts = $.ajax({
                 type: 'GET',
                 url: config.urls.parameterContexts,
-                dataType: 'json'
+                dataType: 'json',
+                data: {
+                    uiOnly: true

Review comment:
       The parameter contexts endpoint does not support the `uiOnly` parameter. Was this added inadvertently?  

##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/util/SnippetUtils.java
##########
@@ -1015,4 +1018,33 @@ private void normalizeCoordinates(Collection<? extends ComponentDTO> components)
         }
     }
 
+    public static void stripNonUiRelevantFields(final ControllerServiceEntity serviceEntity) {

Review comment:
       What was the motivation for adding these methods to `SnippetUtils`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org