[GitHub] [geode] mivanac commented on a diff in pull request #7323: GEODE-9997: added ParallelQueueSetPossibleDuplicateMessage

[GitBox <gi...@apache.org>]

mivanac commented on code in PR #7323:
URL: https://github.com/apache/geode/pull/7323#discussion_r842746811


##########
geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java:
##########
@@ -1160,6 +1169,7 @@ private boolean acquiredPrimaryLock() {
     try {
       synchronized (this) {
         if (isHosting() && (isVolunteering() || isBecomingPrimary())) {
+          hasBecomePrimary = isBecomingPrimary();

Review Comment:
   But, what we need is just indication that we are becoming primary (not volunteering). This is the reason, we are checking only isBecomingPrimary(). Logic is, if bucket is becoming primary (after restart or rebalance), we do not mark all events as possible duplicates (since we will get image from previous primary).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org