You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/10 12:41:40 UTC
[jira] [Commented] (CB-10822) Deduplicate common logic for storing
modules metadata in `cordova_plugins.js`
[ https://issues.apache.org/jira/browse/CB-10822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189178#comment-15189178 ]
ASF GitHub Bot commented on CB-10822:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/408
CB-10822 Manage plugins/modules metadata using PlatformJson
JIRA https://issues.apache.org/jira/browse/CB-10822
This PR adds brings logic for storing and generating plugin metadata into PlatformJson class. The logic is fairly similar for all platforms and relies on PlatformJson as a storage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-10822
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/408.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #408
----
commit 317cfdb374b9dfa215de77c617db0c373dc098c6
Author: riknoll <ri...@gmail.com>
Date: 2016-03-08T00:10:22Z
CB-10679: Improving version choosing logic test coverage
This closes #406
commit ca4f68bae3c4bdefab984855804d9cc72612abaa
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-03-10T11:03:11Z
CB-10822 Manage plugins/modules metadata using PlatformJson
----
> Deduplicate common logic for storing modules metadata in `cordova_plugins.js`
> -----------------------------------------------------------------------------
>
> Key: CB-10822
> URL: https://issues.apache.org/jira/browse/CB-10822
> Project: Apache Cordova
> Issue Type: Task
> Components: Android, CordovaCommon, iOS, Windows
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
>
> One of areas for code deduplidation is Plugin metadata fetching logic ([Android code|https://github.com/apache/cordova-windows/blob/master/template/cordova/Api.js#L372-L472], [Windows code|https://github.com/apache/cordova-windows/blob/master/template/cordova/Api.js#L372-L472], [iOS code|https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/plugman/Plugman.js#L146-L244]): Possible destination of the resultant code is PlatformJson class in cordova-common
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org