You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/06/22 11:21:19 UTC
[GitHub] [brooklyn-ui] algairim opened a new pull request #231: Close confirmation menu if user clicks elswhere on the canvas
algairim opened a new pull request #231:
URL: https://github.com/apache/brooklyn-ui/pull/231
Signed-off-by: Mykola Mandra <my...@cloudsoftcorp.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] asfgit closed pull request #231: Close confirmation menu if user clicks elswhere on the canvas
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #231:
URL: https://github.com/apache/brooklyn-ui/pull/231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #231: Close confirmation menu if user clicks elswhere on the canvas
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #231:
URL: https://github.com/apache/brooklyn-ui/pull/231#discussion_r656123606
##########
File path: ui-modules/blueprint-composer/app/components/util/d3-blueprint.js
##########
@@ -546,7 +547,7 @@ export function D3Blueprint(container, options) {
let root = d3.hierarchy(blueprint);
tree(root);
- _d3DataHolder.nodes = root.descendants();
+ _d3DataHolder.nodes = root.descendants().reverse();
Review comment:
This works ok, I did not notice any side effects so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] ahgittin commented on pull request #231: Close confirmation menu if user clicks elswhere on the canvas
Posted by GitBox <gi...@apache.org>.
ahgittin commented on pull request #231:
URL: https://github.com/apache/brooklyn-ui/pull/231#issuecomment-866726071
looks good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org