[GitHub] srowen commented on a change in pull request #23310: [SPARK-26363][WebUI] Avoid duplicated KV store lookups for task table

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #23310: [SPARK-26363][WebUI] Avoid duplicated KV store lookups for task table
URL: https://github.com/apache/spark/pull/23310#discussion_r242986001
 
 

 ##########
 File path: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
 ##########
 @@ -348,9 +348,9 @@ $(document).ready(function () {
 
             // prepare data for executor summary table
             stageExecutorSummaryInfoKeys = Object.keys(responseBody.executorSummary);
+            var executorDetailsMap = {};
 
 Review comment:
   @gengliangwang you're sure it works locally? I just want to make sure as I'm not sure how well tests cover this case

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org