You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/02 04:27:40 UTC
[jira] [Commented] (DRILL-4287) Do lazy reading of parquet metadata
cache file
[ https://issues.apache.org/jira/browse/DRILL-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127594#comment-15127594 ]
ASF GitHub Bot commented on DRILL-4287:
---------------------------------------
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/345#discussion_r51518520
--- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java ---
@@ -118,13 +133,34 @@ public boolean apply(@Nullable FileStatus status) {
}
}));
- return create(nonDirectories, null, selectionRoot);
+ final FileSelection fileSel = create(nonDirectories, null, selectionRoot);
--- End diff --
Does it make sense to pass in the list of Files in addition to the list of FileStatus? I thought the implicit assumption for FileSelection is list of files goes first before FileStatus.
> Do lazy reading of parquet metadata cache file
> ----------------------------------------------
>
> Key: DRILL-4287
> URL: https://issues.apache.org/jira/browse/DRILL-4287
> Project: Apache Drill
> Issue Type: Bug
> Components: Query Planning & Optimization
> Affects Versions: 1.4.0
> Reporter: Aman Sinha
> Assignee: Jinfeng Ni
>
> Currently, the parquet metadata cache file is read eagerly during creation of the DrillTable (as part of ParquetFormatMatcher.isReadable()). This is not desirable from performance standpoint since there are scenarios where we want to do some up-front optimizations - e.g. directory-based partition pruning (see DRILL-2517) or potential limit 0 optimization etc. - and in such situations it is better to do lazy reading of the metadata cache file.
> This is a placeholder to perform such delayed reading since it is needed for the aforementioned optimizations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)