You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/09/22 14:19:54 UTC
[GitHub] [nifi] sardell commented on a diff in pull request #6437: NIFI-10497: UI updates for making RegistryClient an extension point
sardell commented on code in PR #6437:
URL: https://github.com/apache/nifi/pull/6437#discussion_r977719615
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/registry-configuration-dialog.jsp:
##########
@@ -15,26 +15,45 @@
limitations under the License.
--%>
<%@ page contentType="text/html" pageEncoding="UTF-8" session="false" %>
-<div id="registry-configuration-dialog" layout="column" class="hidden medium-dialog">
+<div id="registry-configuration-dialog" layout="column" class="hidden large-dialog">
+ <div>
+ <div class="clear"></div>
+ </div>
<div class="dialog-content">
- <div class="setting">
- <div class="setting-name">Name</div>
- <div class="setting-field">
- <span id="registry-id" class="hidden"></span>
- <input type="text" id="registry-name" class="setting-input"/>
- </div>
- </div>
- <div class="setting">
- <div class="setting-name">URL</div>
- <div class="setting-field">
- <input type="text" id="registry-location" class="setting-input" placeholder="https://remotehost:8443"/>
+ <div id="registry-configuration-tabs" class="registration-config-tabs tab-container"></div>
+ <div id="registries-tabs-content">
+ <div id="registry-configuration-settings-tab-content">
+ <div id="registry-fields">
+ <div class="setting">
+ <div class="setting-name">Id</div>
+ <div class="setting-field">
+ <span id="registry-id-config"></span>
+ </div>
+ </div>
+ <div class="setting">
+ <div class="setting-name">Name</div>
+ <div class="setting-field">
+ <span id="registry-name-config"></span>
Review Comment:
That was my misunderstanding. @simonbence just pointed this out to me as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org