You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2002/05/18 15:35:37 UTC

DO NOT REPLY [Bug 9222] New: - mod_deflate should check Content-Encoding header

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9222>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9222

mod_deflate should check Content-Encoding header

           Summary: mod_deflate should check Content-Encoding header
           Product: Apache httpd-2.0
           Version: HEAD
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: mod_deflate
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: kaz@asada.sytes.net


Content with "Content-Encoding" header, content is encoded.
But mod_deflate does not check it. It cause to encode content twice.

This problem is reproduceible by get encoded content via mod_proxy.


Following is my trivial patch:
------------------------------------------------------------
--- mod_deflate.c	17 May 2002 11:33:09 -0000	1.5
+++ mod_deflate.c	17 May 2002 16:16:49 -0000
@@ -274,4 +274,11 @@
         }
 
+        /* encoded yet? */
+        accepts = apr_table_get(r->headers_out, "Content-Encoding");
+        if (accepts) {
+
    ap_remove_output_filter(f);
+
    return ap_pass_brigade(f->next, bb);
+
}
+
         /* if they don't have the line, then they can't play */
         accepts = apr_table_get(r->headers_in, "Accept-Encoding");
------------------------------------------------------------

Workaround for existing environment:
------------------------------------------------------------
<IfModule mod_deflate.c>
    SetEnvIf Content-Encoding ".*" no-gzip
</IfModule>
------------------------------------------------------------


Thanks for read my broken English.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org