You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "trushev (via GitHub)" <gi...@apache.org> on 2023/02/08 09:08:37 UTC
[GitHub] [hudi] trushev opened a new pull request, #7895: [WIP] De-coupling column drop flag and schema validation flag in Flink
trushev opened a new pull request, #7895:
URL: https://github.com/apache/hudi/pull/7895
### Change Logs
1. Added column drop check into HoodieTable validation
2. Improved exception message of validation failure
### Impact
Fixed issue:
```sql
-- Step 1.
create table tbl(
`uuid` bigint,
`name` string,
`age` int null, -- column to be dropped
`part` int
) partitioned by (`part`) with (
'connector'='hudi',
'path'='/tmp/tbl',
'hoodie.avro.schema.validate'='false',
'hoodie.datasource.write.schema.allow.auto.evolution.column.drop'='false'
);
insert into tbl values (1, 'Danny', 23, 10);
drop table tbl;
-- Step 2.
create table tbl(
`uuid` bigint,
`name` string,
`part` int
) partitioned by (`part`) with (
'connector'='hudi',
'path'='/tmp/tbl',
'hoodie.avro.schema.validate'='false',
'hoodie.datasource.write.schema.allow.auto.evolution.column.drop'='false'
);
insert into tbl values (2, 'Stephen', 10); -- failure expected
select * from tbl;
```
Expected behavior:
```
Exception -- column dropping is not allowed
```
Actual behavior:
```
+----+-------+----------+-------+
| op | uuid | name | part |
+----+-------+----------+-------+
| +I | 1 | Danny | 10 |
| +I | 2 | Stephen | 10 |
+----+-------+----------+-------+
```
### Risk level (write none, low medium or high below)
Low
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] De-coupling column drop flag and schema validation flag in Flink
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1436694775
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
}, {
"hash" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291",
"triggerID" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"triggerType" : "PUSH"
}, {
"hash" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15293",
"triggerID" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* 1e2cbf9be84665ce707d89f6076d39dfb828bca1 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291)
* 0826821dda5f4562b42d4cd58472449eeb03143c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15293)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] De-coupling column drop flag and schema validation flag in Flink
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1424251956
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* 192a62704a96fe3c67e5017d624e456b6722f02f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] De-coupling column drop flag and schema validation flag in Flink
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1436653898
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
}, {
"hash" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291",
"triggerID" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* 192a62704a96fe3c67e5017d624e456b6722f02f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054)
* 1e2cbf9be84665ce707d89f6076d39dfb828bca1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7895:
URL: https://github.com/apache/hudi/pull/7895#discussion_r1122611190
##########
hudi-common/src/main/java/org/apache/hudi/avro/AvroSchemaUtils.java:
##########
@@ -275,4 +297,33 @@ public static boolean containsFieldInSchema(Schema schema, String fieldName) {
return false;
}
}
+
+ public static void checkSchemaCompatible(
Review Comment:
Let's add some doc to these params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] De-coupling column drop flag and schema validation flag in Flink
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1423683310
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* 192a62704a96fe3c67e5017d624e456b6722f02f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] De-coupling column drop flag and schema validation flag in Flink
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1423652843
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1451571464
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
}, {
"hash" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291",
"triggerID" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"triggerType" : "PUSH"
}, {
"hash" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15293",
"triggerID" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"triggerType" : "PUSH"
}, {
"hash" : "3589751402df73c8fab94b8cafad870222b0042b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15298",
"triggerID" : "3589751402df73c8fab94b8cafad870222b0042b",
"triggerType" : "PUSH"
}, {
"hash" : "c9d463794567d596503a7f9519325b88aa768f26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15531",
"triggerID" : "c9d463794567d596503a7f9519325b88aa768f26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* c9d463794567d596503a7f9519325b88aa768f26 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15531)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] trushev commented on a diff in pull request #7895: [HUDI-5736] De-coupling column drop flag and schema validation flag in Flink
Posted by "trushev (via GitHub)" <gi...@apache.org>.
trushev commented on code in PR #7895:
URL: https://github.com/apache/hudi/pull/7895#discussion_r1101343426
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -799,27 +803,38 @@ public TaskContextSupplier getTaskContextSupplier() {
* GenericRecords with writerSchema. Hence, we need to ensure that this conversion can take place without errors.
*/
private void validateSchema() throws HoodieUpsertException, HoodieInsertException {
-
- if (!shouldValidateAvroSchema() || getActiveTimeline().getCommitsTimeline().filterCompletedInstants().empty()) {
+ boolean allowProjection = config.shouldAllowAutoEvolutionColumnDrop();
+ boolean shouldValidate = shouldValidateAvroSchema();
+ if ((allowProjection && !shouldValidate)
+ || getActiveTimeline().getCommitsTimeline().filterCompletedInstants().empty()) {
// Check not required
return;
}
Schema tableSchema;
Schema writerSchema;
- boolean isValid;
+ String errorMessage = null;
try {
TableSchemaResolver schemaResolver = new TableSchemaResolver(getMetaClient());
writerSchema = HoodieAvroUtils.createHoodieWriteSchema(config.getSchema());
- tableSchema = HoodieAvroUtils.createHoodieWriteSchema(schemaResolver.getTableAvroSchemaWithoutMetadataFields());
- isValid = isSchemaCompatible(tableSchema, writerSchema, config.shouldAllowAutoEvolutionColumnDrop());
+ tableSchema = HoodieAvroUtils.createHoodieWriteSchema(schemaResolver.getTableAvroSchema(false));
+ if (!allowProjection && !AvroSchemaUtils.canProject(tableSchema, writerSchema)) {
+ errorMessage = String.format("Column dropping is not allowed. Use %s to disable this check", SCHEMA_ALLOW_AUTO_EVOLUTION_COLUMN_DROP.key());
+ } else if (shouldValidate && !isSchemaCompatible(tableSchema, writerSchema)) {
Review Comment:
I must admit that I underestimated this task:)
1) Changed `HoodieTable.validate` leads to 9 failed tests in hudi-spark with
```SchemaCompatibilityException: Column dropping is not allowed```. I'm not sure if changed validation is buggy or spark writer. I need more time to look around what's going on
2) There are conflicting options:
`hoodie.datasource.write.drop.partition.columns=true` -- allows column dropping for partition columns. Current implementation(before this PR) skips column dropping check еven though `hoodie.datasource.write.schema.allow.auto.evolution.column.drop=false`
It looks like we should introduce new method `canProjectExceptPartCols(precSchema, newSchema, partCols)`
Mb you are right that `HoodieTableSink` is more appropriate place for these changes to avoid affecting spark. Or mb it is a workaround of `HoodieTable.validate` problem instead of its solution. I'll try to find it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1451658240
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
}, {
"hash" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291",
"triggerID" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"triggerType" : "PUSH"
}, {
"hash" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15293",
"triggerID" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"triggerType" : "PUSH"
}, {
"hash" : "3589751402df73c8fab94b8cafad870222b0042b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15298",
"triggerID" : "3589751402df73c8fab94b8cafad870222b0042b",
"triggerType" : "PUSH"
}, {
"hash" : "c9d463794567d596503a7f9519325b88aa768f26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15531",
"triggerID" : "c9d463794567d596503a7f9519325b88aa768f26",
"triggerType" : "PUSH"
}, {
"hash" : "af0c75f62601109b018a20520b652affbbd19dcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15534",
"triggerID" : "af0c75f62601109b018a20520b652affbbd19dcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* c9d463794567d596503a7f9519325b88aa768f26 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15531)
* af0c75f62601109b018a20520b652affbbd19dcd Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15534)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] De-coupling column drop flag and schema validation flag in Flink
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1436671301
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
}, {
"hash" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291",
"triggerID" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"triggerType" : "PUSH"
}, {
"hash" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* 192a62704a96fe3c67e5017d624e456b6722f02f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054)
* 1e2cbf9be84665ce707d89f6076d39dfb828bca1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291)
* 0826821dda5f4562b42d4cd58472449eeb03143c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1437372046
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
}, {
"hash" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291",
"triggerID" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"triggerType" : "PUSH"
}, {
"hash" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15293",
"triggerID" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"triggerType" : "PUSH"
}, {
"hash" : "3589751402df73c8fab94b8cafad870222b0042b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15298",
"triggerID" : "3589751402df73c8fab94b8cafad870222b0042b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* 3589751402df73c8fab94b8cafad870222b0042b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15298)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7895:
URL: https://github.com/apache/hudi/pull/7895#discussion_r1122594274
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -799,27 +803,38 @@ public TaskContextSupplier getTaskContextSupplier() {
* GenericRecords with writerSchema. Hence, we need to ensure that this conversion can take place without errors.
*/
private void validateSchema() throws HoodieUpsertException, HoodieInsertException {
-
- if (!shouldValidateAvroSchema() || getActiveTimeline().getCommitsTimeline().filterCompletedInstants().empty()) {
+ boolean allowProjection = config.shouldAllowAutoEvolutionColumnDrop();
+ boolean shouldValidate = shouldValidateAvroSchema();
+ if ((allowProjection && !shouldValidate)
+ || getActiveTimeline().getCommitsTimeline().filterCompletedInstants().empty()) {
// Check not required
return;
}
Schema tableSchema;
Schema writerSchema;
- boolean isValid;
+ String errorMessage = null;
try {
TableSchemaResolver schemaResolver = new TableSchemaResolver(getMetaClient());
writerSchema = HoodieAvroUtils.createHoodieWriteSchema(config.getSchema());
- tableSchema = HoodieAvroUtils.createHoodieWriteSchema(schemaResolver.getTableAvroSchemaWithoutMetadataFields());
- isValid = isSchemaCompatible(tableSchema, writerSchema, config.shouldAllowAutoEvolutionColumnDrop());
+ tableSchema = HoodieAvroUtils.createHoodieWriteSchema(schemaResolver.getTableAvroSchema(false));
+ if (!allowProjection && !AvroSchemaUtils.canProject(tableSchema, writerSchema)) {
+ errorMessage = String.format("Column dropping is not allowed. Use %s to disable this check", SCHEMA_ALLOW_AUTO_EVOLUTION_COLUMN_DROP.key());
+ } else if (shouldValidate && !isSchemaCompatible(tableSchema, writerSchema)) {
Review Comment:
Sure, let me take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7895:
URL: https://github.com/apache/hudi/pull/7895#discussion_r1122612112
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -589,11 +589,11 @@ object HoodieSparkSqlWriter {
if (isCompatibleProjectionOf(tableSchema, newSchema)) {
// Picking table schema as a writer schema we need to validate that we'd be able to
// rewrite incoming batch's data (written in new schema) into it
- (tableSchema, isSchemaCompatible(newSchema, tableSchema, true))
Review Comment:
Do you think we still need the validations inside `#deduceWriterSchema` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #7895:
URL: https://github.com/apache/hudi/pull/7895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7895: [HUDI-5736] De-coupling column drop flag and schema validation flag in Flink
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7895:
URL: https://github.com/apache/hudi/pull/7895#discussion_r1101236071
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -799,27 +803,38 @@ public TaskContextSupplier getTaskContextSupplier() {
* GenericRecords with writerSchema. Hence, we need to ensure that this conversion can take place without errors.
*/
private void validateSchema() throws HoodieUpsertException, HoodieInsertException {
-
- if (!shouldValidateAvroSchema() || getActiveTimeline().getCommitsTimeline().filterCompletedInstants().empty()) {
+ boolean allowProjection = config.shouldAllowAutoEvolutionColumnDrop();
+ boolean shouldValidate = shouldValidateAvroSchema();
+ if ((allowProjection && !shouldValidate)
+ || getActiveTimeline().getCommitsTimeline().filterCompletedInstants().empty()) {
// Check not required
return;
}
Schema tableSchema;
Schema writerSchema;
- boolean isValid;
+ String errorMessage = null;
try {
TableSchemaResolver schemaResolver = new TableSchemaResolver(getMetaClient());
writerSchema = HoodieAvroUtils.createHoodieWriteSchema(config.getSchema());
- tableSchema = HoodieAvroUtils.createHoodieWriteSchema(schemaResolver.getTableAvroSchemaWithoutMetadataFields());
- isValid = isSchemaCompatible(tableSchema, writerSchema, config.shouldAllowAutoEvolutionColumnDrop());
+ tableSchema = HoodieAvroUtils.createHoodieWriteSchema(schemaResolver.getTableAvroSchema(false));
+ if (!allowProjection && !AvroSchemaUtils.canProject(tableSchema, writerSchema)) {
+ errorMessage = String.format("Column dropping is not allowed. Use %s to disable this check", SCHEMA_ALLOW_AUTO_EVOLUTION_COLUMN_DROP.key());
+ } else if (shouldValidate && !isSchemaCompatible(tableSchema, writerSchema)) {
Review Comment:
So you mean to move the schema check to the `HoodieTable`, do we still need the validation in the original `HoodieSparkSqlWriter` or should we put these validations in the `HoodieTableSink` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] De-coupling column drop flag and schema validation flag in Flink
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1436577815
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
}, {
"hash" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* 192a62704a96fe3c67e5017d624e456b6722f02f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054)
* 1e2cbf9be84665ce707d89f6076d39dfb828bca1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] De-coupling column drop flag and schema validation flag in Flink
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1436683187
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
}, {
"hash" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291",
"triggerID" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"triggerType" : "PUSH"
}, {
"hash" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* 1e2cbf9be84665ce707d89f6076d39dfb828bca1 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291)
* 0826821dda5f4562b42d4cd58472449eeb03143c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1436973475
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
}, {
"hash" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291",
"triggerID" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"triggerType" : "PUSH"
}, {
"hash" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15293",
"triggerID" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"triggerType" : "PUSH"
}, {
"hash" : "3589751402df73c8fab94b8cafad870222b0042b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3589751402df73c8fab94b8cafad870222b0042b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* 0826821dda5f4562b42d4cd58472449eeb03143c Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15293)
* 3589751402df73c8fab94b8cafad870222b0042b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] trushev commented on a diff in pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "trushev (via GitHub)" <gi...@apache.org>.
trushev commented on code in PR #7895:
URL: https://github.com/apache/hudi/pull/7895#discussion_r1122654358
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -589,11 +589,11 @@ object HoodieSparkSqlWriter {
if (isCompatibleProjectionOf(tableSchema, newSchema)) {
// Picking table schema as a writer schema we need to validate that we'd be able to
// rewrite incoming batch's data (written in new schema) into it
- (tableSchema, isSchemaCompatible(newSchema, tableSchema, true))
Review Comment:
I think we do. The check in `#deduceWriterSchema` is performed at creating rdd stage while `#validateSchema` is part of writing stage. The first check allows us to identify schema incompatibility in advance
##########
hudi-common/src/main/java/org/apache/hudi/avro/AvroSchemaUtils.java:
##########
@@ -76,7 +87,18 @@ public static boolean isSchemaCompatible(Schema prevSchema, Schema newSchema, bo
* @return true if prev schema is a projection of new schema.
*/
public static boolean canProject(Schema prevSchema, Schema newSchema) {
+ return canProject(prevSchema, newSchema, Collections.emptySet());
+ }
+
+ /**
+ * Check that each field in the prevSchema can be populated in the newSchema except specified columns
+ * @param prevSchema prev schema.
+ * @param newSchema new schema
+ * @return true if prev schema is a projection of new schema.
+ */
+ public static boolean canProject(Schema prevSchema, Schema newSchema, Collection<String> exceptCols) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] trushev commented on a diff in pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "trushev (via GitHub)" <gi...@apache.org>.
trushev commented on code in PR #7895:
URL: https://github.com/apache/hudi/pull/7895#discussion_r1122654197
##########
hudi-common/src/main/java/org/apache/hudi/avro/AvroSchemaUtils.java:
##########
@@ -275,4 +297,33 @@ public static boolean containsFieldInSchema(Schema schema, String fieldName) {
return false;
}
}
+
+ public static void checkSchemaCompatible(
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1451580764
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
}, {
"hash" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291",
"triggerID" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"triggerType" : "PUSH"
}, {
"hash" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15293",
"triggerID" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"triggerType" : "PUSH"
}, {
"hash" : "3589751402df73c8fab94b8cafad870222b0042b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15298",
"triggerID" : "3589751402df73c8fab94b8cafad870222b0042b",
"triggerType" : "PUSH"
}, {
"hash" : "c9d463794567d596503a7f9519325b88aa768f26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15531",
"triggerID" : "c9d463794567d596503a7f9519325b88aa768f26",
"triggerType" : "PUSH"
}, {
"hash" : "af0c75f62601109b018a20520b652affbbd19dcd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "af0c75f62601109b018a20520b652affbbd19dcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* c9d463794567d596503a7f9519325b88aa768f26 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15531)
* af0c75f62601109b018a20520b652affbbd19dcd UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7895:
URL: https://github.com/apache/hudi/pull/7895#discussion_r1122613121
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -1041,11 +1040,15 @@ public Runnable getPreExecuteRunnable() {
return Functions.noop();
}
- private boolean shouldValidateAvroSchema() {
- // TODO(HUDI-4772) re-enable validations in case partition columns
- // being dropped from the data-file after fixing the write schema
- Boolean shouldDropPartitionColumns = metaClient.getTableConfig().shouldDropPartitionColumns();
-
- return config.shouldValidateAvroSchema() && !shouldDropPartitionColumns;
+ private Collection<String> getDropPartitionColNames() {
Review Comment:
Return a `Set` instead, so that the invoker knows the return val is an unordered set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7895:
URL: https://github.com/apache/hudi/pull/7895#discussion_r1122612621
##########
hudi-common/src/main/java/org/apache/hudi/avro/AvroSchemaUtils.java:
##########
@@ -76,7 +87,18 @@ public static boolean isSchemaCompatible(Schema prevSchema, Schema newSchema, bo
* @return true if prev schema is a projection of new schema.
*/
public static boolean canProject(Schema prevSchema, Schema newSchema) {
+ return canProject(prevSchema, newSchema, Collections.emptySet());
+ }
+
+ /**
+ * Check that each field in the prevSchema can be populated in the newSchema except specified columns
+ * @param prevSchema prev schema.
+ * @param newSchema new schema
+ * @return true if prev schema is a projection of new schema.
+ */
+ public static boolean canProject(Schema prevSchema, Schema newSchema, Collection<String> exceptCols) {
Review Comment:
Use `Set` instead of `Collection` so that the invoker can ensure the efficiency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] trushev commented on a diff in pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "trushev (via GitHub)" <gi...@apache.org>.
trushev commented on code in PR #7895:
URL: https://github.com/apache/hudi/pull/7895#discussion_r1112485560
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -799,27 +803,38 @@ public TaskContextSupplier getTaskContextSupplier() {
* GenericRecords with writerSchema. Hence, we need to ensure that this conversion can take place without errors.
*/
private void validateSchema() throws HoodieUpsertException, HoodieInsertException {
-
- if (!shouldValidateAvroSchema() || getActiveTimeline().getCommitsTimeline().filterCompletedInstants().empty()) {
+ boolean allowProjection = config.shouldAllowAutoEvolutionColumnDrop();
+ boolean shouldValidate = shouldValidateAvroSchema();
+ if ((allowProjection && !shouldValidate)
+ || getActiveTimeline().getCommitsTimeline().filterCompletedInstants().empty()) {
// Check not required
return;
}
Schema tableSchema;
Schema writerSchema;
- boolean isValid;
+ String errorMessage = null;
try {
TableSchemaResolver schemaResolver = new TableSchemaResolver(getMetaClient());
writerSchema = HoodieAvroUtils.createHoodieWriteSchema(config.getSchema());
- tableSchema = HoodieAvroUtils.createHoodieWriteSchema(schemaResolver.getTableAvroSchemaWithoutMetadataFields());
- isValid = isSchemaCompatible(tableSchema, writerSchema, config.shouldAllowAutoEvolutionColumnDrop());
+ tableSchema = HoodieAvroUtils.createHoodieWriteSchema(schemaResolver.getTableAvroSchema(false));
+ if (!allowProjection && !AvroSchemaUtils.canProject(tableSchema, writerSchema)) {
+ errorMessage = String.format("Column dropping is not allowed. Use %s to disable this check", SCHEMA_ALLOW_AUTO_EVOLUTION_COLUMN_DROP.key());
+ } else if (shouldValidate && !isSchemaCompatible(tableSchema, writerSchema)) {
Review Comment:
@danny0405 Could you pls take a look again
- added canProject(precSchema, newSchema, exceptCols) to avoid collision of `hoodie.datasource.write.schema.allow.auto.evolution.column.drop=false` and `hoodie.datasource.write.drop.partition.columns=true`
- fixed errors in spark by adding `SCHEMA_ALLOW_AUTO_EVOLUTION_COLUMN_DROP.key -> "true"` to spark merge config
- moved the avro schema check to `AvroSchemaUtils` to create unit tests in `TestAvroSchemaUtils`
> do we still need the validation in the original `HoodieSparkSqlWriter`
I think we do because the writer does not use `HoodieTable.validate()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1451827599
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
}, {
"hash" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291",
"triggerID" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"triggerType" : "PUSH"
}, {
"hash" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15293",
"triggerID" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"triggerType" : "PUSH"
}, {
"hash" : "3589751402df73c8fab94b8cafad870222b0042b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15298",
"triggerID" : "3589751402df73c8fab94b8cafad870222b0042b",
"triggerType" : "PUSH"
}, {
"hash" : "c9d463794567d596503a7f9519325b88aa768f26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15531",
"triggerID" : "c9d463794567d596503a7f9519325b88aa768f26",
"triggerType" : "PUSH"
}, {
"hash" : "af0c75f62601109b018a20520b652affbbd19dcd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15534",
"triggerID" : "af0c75f62601109b018a20520b652affbbd19dcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* af0c75f62601109b018a20520b652affbbd19dcd Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15534)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] trushev commented on a diff in pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "trushev (via GitHub)" <gi...@apache.org>.
trushev commented on code in PR #7895:
URL: https://github.com/apache/hudi/pull/7895#discussion_r1122654514
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -1041,11 +1040,15 @@ public Runnable getPreExecuteRunnable() {
return Functions.noop();
}
- private boolean shouldValidateAvroSchema() {
- // TODO(HUDI-4772) re-enable validations in case partition columns
- // being dropped from the data-file after fixing the write schema
- Boolean shouldDropPartitionColumns = metaClient.getTableConfig().shouldDropPartitionColumns();
-
- return config.shouldValidateAvroSchema() && !shouldDropPartitionColumns;
+ private Collection<String> getDropPartitionColNames() {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] trushev commented on pull request #7895: [WIP] De-coupling column drop flag and schema validation flag in Flink
Posted by "trushev (via GitHub)" <gi...@apache.org>.
trushev commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1422266442
@danny0405 Do we need to create new jira ticket for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #7895: [HUDI-5736] De-coupling column drop flag and schema validation flag in Flink
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1423925821
> @danny0405 Do we need to create new jira ticket for this PR?
I think so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] De-coupling column drop flag and schema validation flag in Flink
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1423692951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* 192a62704a96fe3c67e5017d624e456b6722f02f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1436990770
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
}, {
"hash" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291",
"triggerID" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"triggerType" : "PUSH"
}, {
"hash" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15293",
"triggerID" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"triggerType" : "PUSH"
}, {
"hash" : "3589751402df73c8fab94b8cafad870222b0042b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15298",
"triggerID" : "3589751402df73c8fab94b8cafad870222b0042b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* 0826821dda5f4562b42d4cd58472449eeb03143c Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15293)
* 3589751402df73c8fab94b8cafad870222b0042b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15298)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1436902406
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
}, {
"hash" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291",
"triggerID" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"triggerType" : "PUSH"
}, {
"hash" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15293",
"triggerID" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"triggerType" : "PUSH"
}, {
"hash" : "3589751402df73c8fab94b8cafad870222b0042b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3589751402df73c8fab94b8cafad870222b0042b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* 1e2cbf9be84665ce707d89f6076d39dfb828bca1 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291)
* 0826821dda5f4562b42d4cd58472449eeb03143c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15293)
* 3589751402df73c8fab94b8cafad870222b0042b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1451384668
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
}, {
"hash" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291",
"triggerID" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"triggerType" : "PUSH"
}, {
"hash" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15293",
"triggerID" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"triggerType" : "PUSH"
}, {
"hash" : "3589751402df73c8fab94b8cafad870222b0042b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15298",
"triggerID" : "3589751402df73c8fab94b8cafad870222b0042b",
"triggerType" : "PUSH"
}, {
"hash" : "c9d463794567d596503a7f9519325b88aa768f26",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15531",
"triggerID" : "c9d463794567d596503a7f9519325b88aa768f26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* 3589751402df73c8fab94b8cafad870222b0042b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15298)
* c9d463794567d596503a7f9519325b88aa768f26 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15531)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7895: [HUDI-5736] Common de-coupling column drop flag and schema validation flag
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7895:
URL: https://github.com/apache/hudi/pull/7895#issuecomment-1451379144
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0",
"triggerType" : "PUSH"
}, {
"hash" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15054",
"triggerID" : "192a62704a96fe3c67e5017d624e456b6722f02f",
"triggerType" : "PUSH"
}, {
"hash" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15291",
"triggerID" : "1e2cbf9be84665ce707d89f6076d39dfb828bca1",
"triggerType" : "PUSH"
}, {
"hash" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15293",
"triggerID" : "0826821dda5f4562b42d4cd58472449eeb03143c",
"triggerType" : "PUSH"
}, {
"hash" : "3589751402df73c8fab94b8cafad870222b0042b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15298",
"triggerID" : "3589751402df73c8fab94b8cafad870222b0042b",
"triggerType" : "PUSH"
}, {
"hash" : "c9d463794567d596503a7f9519325b88aa768f26",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c9d463794567d596503a7f9519325b88aa768f26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b6dbf0bcc7059a7dc4a5132bf45d0d1451d7fb0 UNKNOWN
* 3589751402df73c8fab94b8cafad870222b0042b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15298)
* c9d463794567d596503a7f9519325b88aa768f26 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org