You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/19 10:32:01 UTC

[GitHub] [shardingsphere] tuichenchuxin opened a new issue #13151: support parsing SHUTDOWN for mysql

tuichenchuxin opened a new issue #13151:
URL: https://github.com/apache/shardingsphere/issues/13151


   Hi community,
   
   This issue can be a good first try.
   
   ## Aim
   support parse mysql administration statements sql `SHUTDOWN`
   
   ## Basic Qualifications
   - java
   - maven
   - antlr4
   
   ## Detail
   We have completed the rule in DALStatement.g4.
   But have not yet implement the visit method in `shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/impl/MySQLDALStatementSQLVisitor.java`
   To complete this issue, I think we should complete these steps:
   - complete `MySQLShutdownStatement` class in this package `org.apache.shardingsphere.sql.parser.sql.dialect.statement.mysql.dal`
   - Add rule in `shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/database/visitor/SQLVisitorRule.java`
   - Implement the visit method in `shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/impl/MySQLDALStatementSQLVisitor.java`. 
   - Finally, add test for parse clone statement in `shardingsphere-test` module
   ## Example FYI
   - Refer to this merged pr:https://github.com/apache/shardingsphere/pull/12979/files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] strongduanmu commented on issue #13151: support parsing SHUTDOWN for mysql

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #13151:
URL: https://github.com/apache/shardingsphere/issues/13151#issuecomment-947254338


   @arthasking123 Welcome, I will assign this issue to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] strongduanmu closed issue #13151: support parsing SHUTDOWN for mysql

Posted by GitBox <gi...@apache.org>.
strongduanmu closed issue #13151:
URL: https://github.com/apache/shardingsphere/issues/13151


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] arthasking123 commented on issue #13151: support parsing SHUTDOWN for mysql

Posted by GitBox <gi...@apache.org>.
arthasking123 commented on issue #13151:
URL: https://github.com/apache/shardingsphere/issues/13151#issuecomment-947243551


   I will try it 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org