You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2019/10/08 21:45:06 UTC
[GitHub] [hive] mustafaiman commented on a change in pull request #803:
HIVE-14302
mustafaiman commented on a change in pull request #803: HIVE-14302
URL: https://github.com/apache/hive/pull/803#discussion_r332747892
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinKey.java
##########
@@ -85,6 +84,7 @@ public static MapJoinKey read(Output output, MapJoinObjectSerDeContext context,
SUPPORTED_PRIMITIVES.add(PrimitiveCategory.BINARY);
SUPPORTED_PRIMITIVES.add(PrimitiveCategory.VARCHAR);
SUPPORTED_PRIMITIVES.add(PrimitiveCategory.CHAR);
+ SUPPORTED_PRIMITIVES.add(PrimitiveCategory.DECIMAL);
Review comment:
Check is not necessary. During planning, common type is used for join keys. This is true when `hive.cbo.enable` is `true` or `false`. See `FunctionRegistry.getCommonClassForComparison`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org