[GitHub] [airflow] XD-DENG commented on a change in pull request #13323: Vastly improves usability of CI logs

[GitBox <gi...@apache.org>]

XD-DENG commented on a change in pull request #13323:
URL: https://github.com/apache/airflow/pull/13323#discussion_r549102378



##########
File path: .github/workflows/ci.yml
##########
@@ -393,12 +390,12 @@ jobs:
         run: ./scripts/ci/provider_packages/ci_prepare_provider_packages.sh
       - name: "Install and test provider packages and airflow via ${{ matrix.package-format }} files"
         run: ./scripts/ci/provider_packages/ci_install_and_test_provider_packages.sh
-      - name: "Upload provider package artifacts"
+      - name: "Upload package artifacts"
         uses: actions/upload-artifact@v2
         if: always()
         with:
           name: airflow-backport-packages
-          path: "./files/airflow-packages-*"
+          path: "./dist/apache*"

Review comment:
       May you share the reason behind this change?

##########
File path: scripts/ci/libraries/_build_images.sh
##########
@@ -898,18 +912,14 @@ function build_images::determine_docker_cache_strategy() {
 
 
 function build_images::build_prod_images_from_packages() {
+    start_end::group_start "PIP download"

Review comment:
       This is duplicated with what you have as 1st line inside function `runs::run_pip_download`

##########
File path: scripts/ci/libraries/_start_end.sh
##########
@@ -16,6 +16,26 @@
 # specific language governing permissions and limitations
 # under the License.
 
+# Starts group for Github Actions - makes logs much more readable
+function start_end::group_start {
+    if [[ ${GITHUB_ACTIONS=} == "true" ]]; then

Review comment:
       ```suggestion
       if [[ ${GITHUB_ACTIONS} == "true" ]]; then
   ```
   
   Should it be like this instead? The same for the one below in `function start_end::group_end` as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org