You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@struts.apache.org by "lukaszlenart (via GitHub)" <gi...@apache.org> on 2026/03/12 07:55:13 UTC

[PR] WW-2963 fix(core): resolve default-action-ref via wildcard matching [struts]

lukaszlenart opened a new pull request, #1623:
URL: https://github.com/apache/struts/pull/1623

   ## Summary
   
   - Port of PR #1614 from Struts 7 to Struts 6.x
   - When `default-action-ref` points to an action name that only exists as a wildcard pattern (e.g. `"movie-input"` matching `"movie-*"`), the framework now falls back to wildcard matching after the exact lookup fails
   - Adds 3 tests covering wildcard resolution, exact match, and no-match scenarios
   
   ## Changes
   
   - **`DefaultConfiguration.java`** — 3-line addition: wildcard matcher fallback after exact `defaultActionRef` lookup fails
   - **`ConfigurationTest.java`** — 3 new tests: `testDefaultActionRefWithWildcard`, `testDefaultActionRefWithExactMatch`, `testDefaultActionRefWithWildcardNoMatch`
   - **`xwork-sample.xml`** — 3 new test packages with corresponding namespaces
   
   ## Test plan
   
   - [x] `./mvnw -pl core test -Dtest=com.opensymphony.xwork2.config.ConfigurationTest` — all 21 tests pass
   - [ ] Full core test suite: `./mvnw -pl core clean test`
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] WW-2963 fix(core): resolve default-action-ref via wildcard matching [struts]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.

sonarqubecloud[bot] commented on PR #1623:
URL: https://github.com/apache/struts/pull/1623#issuecomment-4044766526

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1623) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [24 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=1623&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [42.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1623&metric=new_coverage&view=list) (required ≥ 80%)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [3.4% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1623&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [E Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1623) (required ≥ A)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [E Security Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1623) (required ≥ A)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1623)
   
   ##   
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png '') Catch issues before they fail your Quality Gate with our IDE extension ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png '') [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] WW-2963 fix(core): resolve default-action-ref via wildcard matching [struts]

Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.

lukaszlenart merged PR #1623:
URL: https://github.com/apache/struts/pull/1623


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org