[jira] [Commented] (HBASE-11405) Multiple invocations of hbck in parallel disables balancer permanently

["Jonathan Hsieh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14130514#comment-14130514 ] 

Jonathan Hsieh commented on HBASE-11405:
----------------------------------------

The unit test or the structure of the code likely needs to be modified -- I get this when I try to run the test and this is likely due to the shutdown hook.



{code}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hbase.util.TestHBaseFsck

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
...
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project hbase-server: ExecutionException: java.lang.RuntimeException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd /home/jon/proj/hbase-trunk/hbase-server && /opt/jdk1.7.0_25/jre/bin/java -enableassertions -XX:MaxDirectMemorySize=1G -Xmx1900m -XX:MaxPermSize=256m -Djava.security.egd=file:/dev/./urandom -Djava.net.preferIPv4Stack=true -Djava.awt.headless=true -jar /home/jon/proj/hbase-trunk/hbase-server/target/surefire/surefirebooter6944807203322450992.jar /home/jon/proj/hbase-trunk/hbase-server/target/surefire/surefire1768607263272388944tmp /home/jon/proj/hbase-trunk/hbase-server/target/surefire/surefire_084228475421972179tmp
[ERROR] -> [Help 1]
...
{code}

> Multiple invocations of hbck in parallel disables balancer permanently 
> -----------------------------------------------------------------------
>
>                 Key: HBASE-11405
>                 URL: https://issues.apache.org/jira/browse/HBASE-11405
>             Project: HBase
>          Issue Type: Bug
>          Components: Balancer, hbck
>    Affects Versions: 0.99.0
>            Reporter: bharath v
>            Assignee: bharath v
>         Attachments: HBASE-11405-trunk-rebased.patch, HBASE-11405-trunk.patch, HBASE-11405-trunk.patch.1
>
>
> This is because of the following piece of code in hbck
> {code:borderStyle=solid}
>   boolean oldBalancer = admin.setBalancerRunning(false, true);
>     try {
>       onlineConsistencyRepair();
>     }
>     finally {
>       admin.setBalancerRunning(oldBalancer, false);
>     }
> {code}
> Newer invocations set oldBalancer to false as it was disabled by previous invocations and this disables balancer permanently unless its manually turned on by the user. Easy to reproduce, just run hbck 100 times in a loop in 2 different sessions and you can see that balancer is set to false in the HMaster logs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)