You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by HuangWHWHW <gi...@git.apache.org> on 2015/08/01 11:04:30 UTC
[GitHub] flink pull request: [FLINK-2456][fix]add a repository ID for hadoo...
GitHub user HuangWHWHW opened a pull request:
https://github.com/apache/flink/pull/969
[FLINK-2456][fix]add a repository ID for hadoop2 in flink-hbase module
add a repository for hadoop-2 in flink-hbase.
It can be downloaded through a specified mirror like:
<mirror>
<id>repo2</id>
<name>Human Readable Name for this Mirror.</name>
<url>http://repo2.maven.org/maven2/</url>
<mirrorOf>hadoop-2-repo2</mirrorOf>
</mirror>
Or it will not affect the normal network environment when default.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HuangWHWHW/flink FLINK-2456
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/969.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #969
----
commit 9d6e723d3b6ea1505e739a6f864eff8a5d26e11b
Author: ffbin <86...@qq.com>
Date: 2015-08-01T08:32:48Z
[FLINK-2456][fix]add a repository ID for hadoop2 in flink-hbase module
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2456][fix]add a repository ID for hadoo...
Posted by HuangWHWHW <gi...@git.apache.org>.
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/969#issuecomment-127205807
The most important in the Flink-hbase pom.xml I add is the repository ID:
By using this id, you can get the hadoop-2 from any way(for example using mirror with this ID).
The default repository is the usl(https://repo.maven.apache.org/maven2) above.
And the default means you need not do anything with maven configuration just print "mvn pakcage".
As I see, every flink dependency is using this url.
Did I misunderstand?Is the hadoop-2 default repository path is another?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2456][fix]add a repository ID for hadoo...
Posted by HuangWHWHW <gi...@git.apache.org>.
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/969#issuecomment-127205220
The most important in the Flink-hbase pom.xml I add is the repository ID:
"<!--"
"<repositories>"
"<repository>"
"<id>hadoop-2-repo2</id>"
"<url>https://repo.maven.apache.org/maven2</url>"
"<releases>"
"<enabled>true</enabled>"
"</releases>"
"<snapshots>"
"<enabled>false</enabled>"
"</snapshots>"
"</repository>"
"</repositories>"
"-->"
By using this id, you can get the hadoop-2 from any way(for example using mirror with this ID).
The default repository is the usl(https://repo.maven.apache.org/maven2) above.
And the default means you need not do anything with maven configuration just print "mvn pakcage".
As I see, every flink dependency is using this url.
Did I misunderstand?Is the hadoop-2 default repository path is another?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2456][fix]add a repository ID for hadoo...
Posted by HuangWHWHW <gi...@git.apache.org>.
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/969#issuecomment-127105581
This is just a method to solve the problem that some modules' dependencies cannot be downloaded from central maven repository.
You can specify every module dependency ID so that we can downloading dependencies from either central maven repository by default or other channel by setting maven mirrors when mvn package.
As for HBase, it`s just that I get some trouble in downloading this module dependency.
And sorry for the url.
I just want to push a example about maven mirror on the comment but it was blocked because of the XML format.
This complete code should be like this:
"<mirror>"
"<id>repo2</id>"
"<name>Human Readable Name for this Mirror.</name>"
"<url>http://repo2.maven.org/maven2/</url>"
"<mirrorOf>hadoop-2-repo2</mirrorOf>"
"</mirror>"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2456][fix]add a repository ID for hadoo...
Posted by HuangWHWHW <gi...@git.apache.org>.
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/969#issuecomment-127203020
The most important In the HBase pom.xml I add is the repository ID:
"<repositories>"
"<repository>"
"<id>hadoop-2-repo2</id>"
"<url>https://repo.maven.apache.org/maven2</url>"
"<releases>"
"<enabled>true</enabled>"
"</releases>"
"<snapshots>"
"<enabled>false</enabled>"
"</snapshots>"
"</repository>"
"</repositories>"
By using this id, you can get the hadoop-2 from any way(for example using mirror with this ID).
The default repository is the url(https://repo.maven.apache.org/maven2) above.
And the default means you need not do anything with maven configuration just print "mvn package".
As I see, every flink dependency is using this url.
Did I misunderstand? Is the hadoop-2 default repository path is another?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2456][fix]add a repository ID for hadoo...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/969#issuecomment-127183500
The repository you add is the default Maven repository - it should be used by default anyways.
Is the change there override your mirror repository for HBase with the default repository?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2456][fix]add a repository ID for hadoo...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/969#issuecomment-127036573
Thanks for providing this path!
Can you help us understand this fix a bit? Why is this extra repository entry required for the HBase module, and not for any other modules?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2456][fix]add a repository ID for hadoo...
Posted by HuangWHWHW <gi...@git.apache.org>.
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/969#issuecomment-127443533
My plessure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2456][fix]add a repository ID for hadoo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/969
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2456][fix]add a repository ID for hadoo...
Posted by HuangWHWHW <gi...@git.apache.org>.
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/969#issuecomment-127202065
The most important In the HBase pom.xml I add is the repository ID:
"<repositories>"
" <repository>"
" <id>hadoop-2-repo2</id>"
" <url>https://repo.maven.apache.org/maven2</url>"
" <releases>"
" <enabled>true</enabled>"
" </releases>"
" <snapshots>"
" <enabled>false</enabled>"
" </snapshots>"
" </repository>"
" </repositories>"
By using this id, you can get the hadoop-2 from any way(for example using mirror with this ID).
The default repository is the url(https://repo.maven.apache.org/maven2) above.
And the default means you need not do anything with maven configuration just print "mvn package".
As I see, every flink dependency is using this url.
Did I misunderstand? Is the hadoop-2 default repository path is another?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2456][fix]add a repository ID for hadoo...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/969#issuecomment-127370925
Thank you for taking the time to explain the reason behind this issue...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2456][fix]add a repository ID for hadoo...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/969#issuecomment-127370745
I understand.
Will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---