You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/20 03:16:46 UTC
[GitHub] [flink] openinx opened a new pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
openinx opened a new pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637
## What is the purpose of the change
Make the e2e package download timeout to be configurable. For example, we can tuning the timeout by the following command:
```bash
mvn verify \
-pl org.apache.flink:flink-end-to-end-tests-common-kafka \
-DdistDir=/Users/openinx/software/flink/build-target \
-DincludeE2E=org.apache.flink.tests.util.categories.TravisGroup1
-DdownloadTimeout=180000 # set it to 3 min
```
BTW, if you don't set the `downloadTimeout` property, then it will use the default 5min.
## Brief change log
- Increase the default package download timeout to 5min and make it to be configurable.
## Verifying this change
This change does not have a test.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r364709925
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -117,14 +117,13 @@ public void runBlocking(final Duration timeout) throws IOException {
public void runBlockingWithRetry(final int maxRetries, final Duration attemptTimeout, final Duration globalTimeout) throws IOException {
int retries = 0;
- Duration remainTimeout = globalTimeout;
+ long expectedTimeMillis = System.currentTimeMillis() + globalTimeout.toMillis();
Review comment:
You can simplify the global timeout handling by converting it to a `Deadline` and using `#hasTimeLeft` as the exit condition:
```
Deadline deadline = Deadline.fromNow(globalTimeout);
while (true) {
...
} catch (Exception e) {
if (++retries > maxRetries || !deadline.hasTimeLeft) {
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r364709925
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -117,14 +117,13 @@ public void runBlocking(final Duration timeout) throws IOException {
public void runBlockingWithRetry(final int maxRetries, final Duration attemptTimeout, final Duration globalTimeout) throws IOException {
int retries = 0;
- Duration remainTimeout = globalTimeout;
+ long expectedTimeMillis = System.currentTimeMillis() + globalTimeout.toMillis();
Review comment:
You can simplify the global timeout handling by converting it to a `Deadline` and using `#hasTimeLeft` as the exit condition:
```
Deadline deadline = Deadline.fromNow(globalTimeout);
while (true) {
...
} catch (Exception e) {
if (++retries > maxRetries || (!deadline.hasTimeLeft)) {
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] openinx commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
openinx commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r365559972
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -117,14 +117,13 @@ public void runBlocking(final Duration timeout) throws IOException {
public void runBlockingWithRetry(final int maxRetries, final Duration attemptTimeout, final Duration globalTimeout) throws IOException {
int retries = 0;
- Duration remainTimeout = globalTimeout;
+ long expectedTimeMillis = System.currentTimeMillis() + globalTimeout.toMillis();
Review comment:
Just saw the comment, thanks for the comment and appended commit, You are very nice. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r362815938
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -115,6 +115,22 @@ public void runBlocking(final Duration timeout) throws IOException {
}
}
+ public void runBlockingWithRetry(final int maxRetries, final Duration timeoutOfTry) throws IOException {
+ int retries = 0;
+ while (true) {
+ try {
+ runBlocking(timeoutOfTry);
+ break;
+ } catch (Throwable e) {
Review comment:
We should only catch exceptions; throwables here would indicate some significant problem with the code for which we just want to fail right away.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#issuecomment-567778216
<!--
Meta data
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141861783 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142183261 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143188890 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
-->
## CI report:
* eec2a87ddc2fa8bd32e598d4f715259e09792a73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141861783) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793)
* 6427c34b6bbef5ea52963c380cb9fa255e330a01 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142183261) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869)
* 2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143188890) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r362814545
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/cache/AbstractDownloadCache.java
##########
@@ -91,6 +91,30 @@ public void afterTestSuccess() {
abstract boolean matchesCachedFile(Matcher matcher, String url);
+ private long getDownloadTimeoutMillis() {
+ String downloadTimeoutProp = System.getProperty("downloadTimeoutMillis");
+ long downloadTimeout = 5 * 60 * 1000; // default 5min.
+ if (downloadTimeoutProp != null && downloadTimeoutProp.length() > 0) {
+ downloadTimeout = Long.parseLong(downloadTimeoutProp);
+ if (downloadTimeout <= 0) {
+ throw new IllegalArgumentException("Illegal property setting: -DdownloadTimeoutMillis=" + downloadTimeoutProp);
+ }
+ }
+ return downloadTimeout;
+ }
+
+ private int getDownloadMaxRetries() {
+ String downloadMaxRetriesProp = System.getProperty("downloadMaxRetries");
Review comment:
Let's refactor this to be a `ParameterProperty`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#issuecomment-567778216
<!--
Meta data
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141861783 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142183261 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143188890 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
Hash:b3b7285b48a1242c537b233b28ade9df0aa7baa5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4114 TriggerType:PUSH TriggerID:b3b7285b48a1242c537b233b28ade9df0aa7baa5
Hash:b3b7285b48a1242c537b233b28ade9df0aa7baa5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143204296 TriggerType:PUSH TriggerID:b3b7285b48a1242c537b233b28ade9df0aa7baa5
Hash:dd4058a5554fa292a60247e294084e6215e24bb5 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:dd4058a5554fa292a60247e294084e6215e24bb5
-->
## CI report:
* eec2a87ddc2fa8bd32e598d4f715259e09792a73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141861783) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793)
* 6427c34b6bbef5ea52963c380cb9fa255e330a01 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142183261) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869)
* 2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143188890) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105)
* b3b7285b48a1242c537b233b28ade9df0aa7baa5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143204296) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4114)
* dd4058a5554fa292a60247e294084e6215e24bb5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#issuecomment-567778216
<!--
Meta data
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141861783 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
-->
## CI report:
* eec2a87ddc2fa8bd32e598d4f715259e09792a73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141861783) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793)
* 6427c34b6bbef5ea52963c380cb9fa255e330a01 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#issuecomment-567778216
<!--
Meta data
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141861783 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142183261 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143188890 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
Hash:b3b7285b48a1242c537b233b28ade9df0aa7baa5 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b3b7285b48a1242c537b233b28ade9df0aa7baa5
-->
## CI report:
* eec2a87ddc2fa8bd32e598d4f715259e09792a73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141861783) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793)
* 6427c34b6bbef5ea52963c380cb9fa255e330a01 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142183261) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869)
* 2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143188890) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105)
* b3b7285b48a1242c537b233b28ade9df0aa7baa5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] openinx commented on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
openinx commented on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#issuecomment-568944601
Ping @zentol
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#issuecomment-567778216
<!--
Meta data
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141861783 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142183261 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143188890 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
Hash:b3b7285b48a1242c537b233b28ade9df0aa7baa5 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4114 TriggerType:PUSH TriggerID:b3b7285b48a1242c537b233b28ade9df0aa7baa5
Hash:b3b7285b48a1242c537b233b28ade9df0aa7baa5 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143204296 TriggerType:PUSH TriggerID:b3b7285b48a1242c537b233b28ade9df0aa7baa5
-->
## CI report:
* eec2a87ddc2fa8bd32e598d4f715259e09792a73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141861783) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793)
* 6427c34b6bbef5ea52963c380cb9fa255e330a01 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142183261) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869)
* 2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143188890) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105)
* b3b7285b48a1242c537b233b28ade9df0aa7baa5 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143204296) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4114)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] openinx commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
openinx commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r363143808
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/cache/AbstractDownloadCache.java
##########
@@ -91,6 +91,30 @@ public void afterTestSuccess() {
abstract boolean matchesCachedFile(Matcher matcher, String url);
+ private long getDownloadTimeoutMillis() {
+ String downloadTimeoutProp = System.getProperty("downloadTimeoutMillis");
+ long downloadTimeout = 5 * 60 * 1000; // default 5min.
+ if (downloadTimeoutProp != null && downloadTimeoutProp.length() > 0) {
+ downloadTimeout = Long.parseLong(downloadTimeoutProp);
+ if (downloadTimeout <= 0) {
+ throw new IllegalArgumentException("Illegal property setting: -DdownloadTimeoutMillis=" + downloadTimeoutProp);
+ }
+ }
+ return downloadTimeout;
+ }
+
+ private int getDownloadMaxRetries() {
+ String downloadMaxRetriesProp = System.getProperty("downloadMaxRetries");
Review comment:
Really good advise, will do the refactor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#issuecomment-567778216
<!--
Meta data
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141861783 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142183261 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143188890 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
-->
## CI report:
* eec2a87ddc2fa8bd32e598d4f715259e09792a73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141861783) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793)
* 6427c34b6bbef5ea52963c380cb9fa255e330a01 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142183261) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869)
* 2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143188890) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] openinx commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
openinx commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r363143934
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -115,6 +115,22 @@ public void runBlocking(final Duration timeout) throws IOException {
}
}
+ public void runBlockingWithRetry(final int maxRetries, final Duration timeoutOfTry) throws IOException {
+ int retries = 0;
+ while (true) {
+ try {
+ runBlocking(timeoutOfTry);
+ break;
+ } catch (Throwable e) {
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] openinx commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
openinx commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r363143938
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -115,6 +115,22 @@ public void runBlocking(final Duration timeout) throws IOException {
}
}
+ public void runBlockingWithRetry(final int maxRetries, final Duration timeoutOfTry) throws IOException {
+ int retries = 0;
+ while (true) {
+ try {
+ runBlocking(timeoutOfTry);
+ break;
+ } catch (Throwable e) {
+ if (++retries > maxRetries) {
+ LOG.info("Exhausted to run the blocking process: {}. maxRetries={}, timeoutOfTry={} (ms)",
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] openinx commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
openinx commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r363143922
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -115,6 +115,22 @@ public void runBlocking(final Duration timeout) throws IOException {
}
}
+ public void runBlockingWithRetry(final int maxRetries, final Duration timeoutOfTry) throws IOException {
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#issuecomment-567778216
<!--
Meta data
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141861783 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142183261 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143188890 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
Hash:b3b7285b48a1242c537b233b28ade9df0aa7baa5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4114 TriggerType:PUSH TriggerID:b3b7285b48a1242c537b233b28ade9df0aa7baa5
Hash:b3b7285b48a1242c537b233b28ade9df0aa7baa5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143204296 TriggerType:PUSH TriggerID:b3b7285b48a1242c537b233b28ade9df0aa7baa5
-->
## CI report:
* eec2a87ddc2fa8bd32e598d4f715259e09792a73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141861783) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793)
* 6427c34b6bbef5ea52963c380cb9fa255e330a01 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142183261) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869)
* 2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143188890) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105)
* b3b7285b48a1242c537b233b28ade9df0aa7baa5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143204296) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4114)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#issuecomment-567778216
<!--
Meta data
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141861783 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142183261 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
-->
## CI report:
* eec2a87ddc2fa8bd32e598d4f715259e09792a73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141861783) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793)
* 6427c34b6bbef5ea52963c380cb9fa255e330a01 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142183261) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#issuecomment-567778216
<!--
Meta data
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141861783 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142183261 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
-->
## CI report:
* eec2a87ddc2fa8bd32e598d4f715259e09792a73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141861783) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793)
* 6427c34b6bbef5ea52963c380cb9fa255e330a01 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142183261) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] openinx commented on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
openinx commented on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#issuecomment-568631152
@zentol well, I like the idea to make it retry the downloading, let me update the patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r362814475
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/cache/AbstractDownloadCache.java
##########
@@ -102,13 +126,16 @@ public Path getOrDownload(final String url, final Path targetDir) throws IOExcep
} else {
final Path scopedDownloadDir = downloadsDir.resolve(String.valueOf(url.hashCode()));
Files.createDirectories(scopedDownloadDir);
- log.info("Downloading {}.", url);
+
+ long downloadTimeoutMillis = getDownloadTimeoutMillis();
+ int maxRetries = getDownloadMaxRetries();
+ log.info("Downloading {} with maxRetries={}, and timeout of one retry is {} (ms).", url, maxRetries, downloadTimeoutMillis);
AutoClosableProcess
- .create(
- CommandLineWrapper.wget(url)
- .targetDir(scopedDownloadDir)
- .build())
- .runBlocking(Duration.ofMinutes(2));
+ .create(
Review comment:
revert indentation change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r362815280
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -115,6 +115,22 @@ public void runBlocking(final Duration timeout) throws IOException {
}
}
+ public void runBlockingWithRetry(final int maxRetries, final Duration timeoutOfTry) throws IOException {
Review comment:
rename `timeoutOfTry` to `attemptTimeout`; an additional global timeout may also be useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] openinx commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
openinx commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r363143871
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/cache/AbstractDownloadCache.java
##########
@@ -91,6 +91,30 @@ public void afterTestSuccess() {
abstract boolean matchesCachedFile(Matcher matcher, String url);
+ private long getDownloadTimeoutMillis() {
Review comment:
Yeah, good points.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#issuecomment-567778216
<!--
Meta data
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141861783 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142183261 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143188890 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
-->
## CI report:
* eec2a87ddc2fa8bd32e598d4f715259e09792a73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141861783) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793)
* 6427c34b6bbef5ea52963c380cb9fa255e330a01 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142183261) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869)
* 2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143188890) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#issuecomment-567778216
<!--
Meta data
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141861783 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142183261 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143188890 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
Hash:b3b7285b48a1242c537b233b28ade9df0aa7baa5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4114 TriggerType:PUSH TriggerID:b3b7285b48a1242c537b233b28ade9df0aa7baa5
Hash:b3b7285b48a1242c537b233b28ade9df0aa7baa5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143204296 TriggerType:PUSH TriggerID:b3b7285b48a1242c537b233b28ade9df0aa7baa5
Hash:dd4058a5554fa292a60247e294084e6215e24bb5 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143885965 TriggerType:PUSH TriggerID:dd4058a5554fa292a60247e294084e6215e24bb5
Hash:dd4058a5554fa292a60247e294084e6215e24bb5 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4256 TriggerType:PUSH TriggerID:dd4058a5554fa292a60247e294084e6215e24bb5
-->
## CI report:
* eec2a87ddc2fa8bd32e598d4f715259e09792a73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141861783) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793)
* 6427c34b6bbef5ea52963c380cb9fa255e330a01 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142183261) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869)
* 2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143188890) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105)
* b3b7285b48a1242c537b233b28ade9df0aa7baa5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143204296) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4114)
* dd4058a5554fa292a60247e294084e6215e24bb5 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143885965) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4256)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#issuecomment-567778216
<!--
Meta data
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141861783 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142183261 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
-->
## CI report:
* eec2a87ddc2fa8bd32e598d4f715259e09792a73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141861783) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793)
* 6427c34b6bbef5ea52963c380cb9fa255e330a01 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142183261) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#issuecomment-567778216
<!--
Meta data
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141861783 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142183261 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
-->
## CI report:
* eec2a87ddc2fa8bd32e598d4f715259e09792a73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141861783) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793)
* 6427c34b6bbef5ea52963c380cb9fa255e330a01 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142183261) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869)
* 2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r362813557
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/cache/AbstractDownloadCache.java
##########
@@ -91,6 +91,30 @@ public void afterTestSuccess() {
abstract boolean matchesCachedFile(Matcher matcher, String url);
+ private long getDownloadTimeoutMillis() {
Review comment:
Let's refactor this to
a) be a `ParameterProperty<Duration>`
b) use `TimeUtils#parseDuration` for parsing
c) rename the property to `downloadTimeout` since with b) we can support any time unit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r364301349
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/cache/AbstractDownloadCache.java
##########
@@ -102,13 +126,16 @@ public Path getOrDownload(final String url, final Path targetDir) throws IOExcep
} else {
final Path scopedDownloadDir = downloadsDir.resolve(String.valueOf(url.hashCode()));
Files.createDirectories(scopedDownloadDir);
- log.info("Downloading {}.", url);
+
+ long downloadTimeoutMillis = getDownloadTimeoutMillis();
+ int maxRetries = getDownloadMaxRetries();
+ log.info("Downloading {} with maxRetries={}, and timeout of one retry is {} (ms).", url, maxRetries, downloadTimeoutMillis);
AutoClosableProcess
- .create(
- CommandLineWrapper.wget(url)
- .targetDir(scopedDownloadDir)
- .build())
- .runBlocking(Duration.ofMinutes(2));
+ .create(
Review comment:
we don't have a standard indentation; to prevent people from changing things back and forth we hence discourage indentation changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#issuecomment-567778216
<!--
Meta data
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141861783 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:eec2a87ddc2fa8bd32e598d4f715259e09792a73 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793 TriggerType:PUSH TriggerID:eec2a87ddc2fa8bd32e598d4f715259e09792a73
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:6427c34b6bbef5ea52963c380cb9fa255e330a01 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142183261 TriggerType:PUSH TriggerID:6427c34b6bbef5ea52963c380cb9fa255e330a01
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
Hash:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143188890 TriggerType:PUSH TriggerID:2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321
Hash:b3b7285b48a1242c537b233b28ade9df0aa7baa5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4114 TriggerType:PUSH TriggerID:b3b7285b48a1242c537b233b28ade9df0aa7baa5
Hash:b3b7285b48a1242c537b233b28ade9df0aa7baa5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143204296 TriggerType:PUSH TriggerID:b3b7285b48a1242c537b233b28ade9df0aa7baa5
Hash:dd4058a5554fa292a60247e294084e6215e24bb5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143885965 TriggerType:PUSH TriggerID:dd4058a5554fa292a60247e294084e6215e24bb5
Hash:dd4058a5554fa292a60247e294084e6215e24bb5 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4256 TriggerType:PUSH TriggerID:dd4058a5554fa292a60247e294084e6215e24bb5
-->
## CI report:
* eec2a87ddc2fa8bd32e598d4f715259e09792a73 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141861783) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3793)
* 6427c34b6bbef5ea52963c380cb9fa255e330a01 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142183261) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3869)
* 2d85797e2f74dfb5836b7fbe89e2e50e0fcb0321 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143188890) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4105)
* b3b7285b48a1242c537b233b28ade9df0aa7baa5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143204296) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4114)
* dd4058a5554fa292a60247e294084e6215e24bb5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143885965) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4256)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] openinx commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
openinx commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r363143736
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/cache/AbstractDownloadCache.java
##########
@@ -102,13 +126,16 @@ public Path getOrDownload(final String url, final Path targetDir) throws IOExcep
} else {
final Path scopedDownloadDir = downloadsDir.resolve(String.valueOf(url.hashCode()));
Files.createDirectories(scopedDownloadDir);
- log.info("Downloading {}.", url);
+
+ long downloadTimeoutMillis = getDownloadTimeoutMillis();
+ int maxRetries = getDownloadMaxRetries();
+ log.info("Downloading {} with maxRetries={}, and timeout of one retry is {} (ms).", url, maxRetries, downloadTimeoutMillis);
AutoClosableProcess
- .create(
- CommandLineWrapper.wget(url)
- .targetDir(scopedDownloadDir)
- .build())
- .runBlocking(Duration.ofMinutes(2));
+ .create(
Review comment:
The new indentation should be right here, so I think we can keep the change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r362816955
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/AutoClosableProcess.java
##########
@@ -115,6 +115,22 @@ public void runBlocking(final Duration timeout) throws IOException {
}
}
+ public void runBlockingWithRetry(final int maxRetries, final Duration timeoutOfTry) throws IOException {
+ int retries = 0;
+ while (true) {
+ try {
+ runBlocking(timeoutOfTry);
+ break;
+ } catch (Throwable e) {
+ if (++retries > maxRetries) {
+ LOG.info("Exhausted to run the blocking process: {}. maxRetries={}, timeoutOfTry={} (ms)",
Review comment:
should be included in the exception message like in `runBlocking`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services