You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jkbradley <gi...@git.apache.org> on 2018/05/17 22:13:30 UTC

[GitHub] spark pull request #21358: [SPARK-22884][ML] ML tests for StructuredStreamin...

GitHub user jkbradley opened a pull request:

    https://github.com/apache/spark/pull/21358

    [SPARK-22884][ML] ML tests for StructuredStreaming: spark.ml.clustering

    ## What changes were proposed in this pull request?
    
    Converting clustering tests to also check code with structured streaming, using the ML testing infrastructure implemented in SPARK-22882.
    
    This PR is a new version of https://github.com/apache/spark/pull/20319

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkbradley/spark smurakozi-SPARK-22884

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21358
    
----
commit 496bc7ba688260317fe5907a8057347a5b184490
Author: Sandor Murakozi <sm...@...>
Date:   2018-01-18T19:03:33Z

    Converted all clustering tests to check streaming

commit 58239ba3edc0c60900d842caf3d38e30507d885f
Author: Sandor Murakozi <sm...@...>
Date:   2018-01-18T20:12:46Z

    formatting, nits

commit eb66659e8b65de9d539584b935899838e1dd9ed8
Author: Joseph K. Bradley <jo...@...>
Date:   2018-05-17T21:26:17Z

    cleanups

commit 95f6f2919a5ab0853434592000f5b811915ca15f
Author: Joseph K. Bradley <jo...@...>
Date:   2018-05-17T22:11:20Z

    more cleanups

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #21358: [SPARK-22884][ML] ML tests for StructuredStreamin...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/21358


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21358: [SPARK-22884][ML] ML tests for StructuredStreaming: spar...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21358
  
    **[Test build #90757 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90757/testReport)** for PR 21358 at commit [`95f6f29`](https://github.com/apache/spark/commit/95f6f2919a5ab0853434592000f5b811915ca15f).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21358: [SPARK-22884][ML] ML tests for StructuredStreaming: spar...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21358
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90757/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21358: [SPARK-22884][ML] ML tests for StructuredStreaming: spar...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21358
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21358: [SPARK-22884][ML] ML tests for StructuredStreaming: spar...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21358
  
    **[Test build #90757 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90757/testReport)** for PR 21358 at commit [`95f6f29`](https://github.com/apache/spark/commit/95f6f2919a5ab0853434592000f5b811915ca15f).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21358: [SPARK-22884][ML] ML tests for StructuredStreaming: spar...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21358
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21358: [SPARK-22884][ML] ML tests for StructuredStreaming: spar...

Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the issue:

    https://github.com/apache/spark/pull/21358
  
    LGTM. Merged into master. Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21358: [SPARK-22884][ML] ML tests for StructuredStreaming: spar...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21358
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3311/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org