You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2017/08/30 03:24:16 UTC

[GitHub] activemq-artemis pull request #1496: ARTEMIS-1379 MessagesAdded & MessagesAc...

GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1496

    ARTEMIS-1379 MessagesAdded & MessagesAcknowledged not threadsafe

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1379

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1496.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1496
    
----
commit 5fa86685f26e5e77b752d355c4ddcf8b79785eee
Author: Justin Bertram <jb...@apache.org>
Date:   2017-08-30T03:13:27Z

    ARTEMIS-1379 MessagesAdded & MessagesAcknowledged not threadsafe

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1496: ARTEMIS-1379 MessagesAdded & MessagesAc...

Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1496#discussion_r135966165
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java ---
    @@ -177,9 +177,9 @@
     
        private final ScheduledDeliveryHandler scheduledDeliveryHandler;
     
    -   private long messagesAdded;
    +   private AtomicLong messagesAdded = new AtomicLong(0);
    --- End diff --
    
    To be more memory friendly where lots of queues can the long be volatile and then use a AtomicLongFieldUpdater to safely update.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1496: ARTEMIS-1379 Some queue stats not threadsafe

Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1496
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1496: ARTEMIS-1379 Some queue stats not threa...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1496


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1496: ARTEMIS-1379 MessagesAdded & MessagesAcknowled...

Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1496
  
    Removed prev comment (as if needed should probably be a larger overhaul piece of work), and approved.
    
    On another note, whilst not directly under the JIRA-1379, it looks like messagesExpired and messagesKilled have the same thread safe issue. Do you want to do under this ticket? Or want me to raise separate jira and me to do a separate PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1496: ARTEMIS-1379 MessagesAdded & MessagesAcknowled...

Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1496
  
    @michaelandrepearce, yes.  I'll update messagesExpired & messagesKilled as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---