You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "AHeise (via GitHub)" <gi...@apache.org> on 2024/10/18 13:28:42 UTC
[PR] [FLINK-36455] Sinks retry synchronously [flink]
AHeise opened a new pull request, #25547:
URL: https://github.com/apache/flink/pull/25547
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Sinks so far retried asynchronously to increase commit throughput in case of temporary issues. However, the contract of notifyCheckpointCompleted states that checkpoints must be side-effect free meaning all transactions have to be committed on return of the PRC call.
## Brief change log
* This commit retries a fixed number of times and then fails in notifyCheckpointCompleted.
* Simplifies parts of committable handling now that all committables of a subtask either succeed or fail
## Verifying this change
* Already covered by many tests
* Adjusted and changed tests in
api/connector/sink2
runtime/operators/sink/committables
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (**yes** / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]
Posted by "AHeise (via GitHub)" <gi...@apache.org>.
AHeise merged PR #25547:
URL: https://github.com/apache/flink/pull/25547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]
Posted by "fapaul (via GitHub)" <gi...@apache.org>.
fapaul commented on code in PR #25547:
URL: https://github.com/apache/flink/pull/25547#discussion_r1818576013
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableSummary.java:
##########
@@ -39,11 +39,21 @@ public class CommittableSummary<CommT> implements CommittableMessage<CommT> {
private final long checkpointId;
/** The number of committables coming from the given subtask in the particular checkpoint. */
private final int numberOfCommittables;
+
+ @Deprecated
/** The number of committables that have not been successfully committed. */
private final int numberOfPendingCommittables;
+
+ @Deprecated
/** The number of committables that are not retried and have been failed. */
private final int numberOfFailedCommittables;
Review Comment:
Why do we deprecate failed committables? I still see some value to provide the possibility to discard unrecoverable committables. The change also looks unrelated to the retry mechanism.
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperator.java:
##########
@@ -164,41 +165,37 @@ public void notifyCheckpointComplete(long checkpointId) throws Exception {
private void commitAndEmitCheckpoints() throws IOException, InterruptedException {
long completedCheckpointId = endInput ? EOI : lastCompletedCheckpointId;
- do {
- for (CheckpointCommittableManager<CommT> manager :
- committableCollector.getCheckpointCommittablesUpTo(completedCheckpointId)) {
- commitAndEmit(manager);
- }
- // !committableCollector.isFinished() indicates that we should retry
- // Retry should be done here if this is a final checkpoint (indicated by endInput)
- // WARN: this is an endless retry, may make the job stuck while finishing
- } while (!committableCollector.isFinished() && endInput);
-
- if (!committableCollector.isFinished()) {
- // if not endInput, we can schedule retrying later
- retryWithDelay();
+ for (CheckpointCommittableManager<CommT> checkpointManager :
+ committableCollector.getCheckpointCommittablesUpTo(completedCheckpointId)) {
+ // ensure that all committables of the first checkpoint are fully committed before
+ // attempting the next committable
+ commitAndEmit(checkpointManager);
+ committableCollector.remove(checkpointManager);
}
- committableCollector.compact();
}
private void commitAndEmit(CheckpointCommittableManager<CommT> committableManager)
throws IOException, InterruptedException {
- Collection<CommittableWithLineage<CommT>> committed = committableManager.commit(committer);
- if (emitDownstream && committableManager.isFinished()) {
- int subtaskId = getRuntimeContext().getTaskInfo().getIndexOfThisSubtask();
- int numberOfSubtasks = getRuntimeContext().getTaskInfo().getNumberOfParallelSubtasks();
- output.collect(
- new StreamRecord<>(committableManager.getSummary(subtaskId, numberOfSubtasks)));
- for (CommittableWithLineage<CommT> committable : committed) {
- output.collect(new StreamRecord<>(committable.withSubtaskId(subtaskId)));
- }
+ committableManager.commit(committer, MAX_RETRIES);
+ if (emitDownstream) {
+ emit(committableManager);
}
}
- private void retryWithDelay() {
- processingTimeService.registerTimer(
- processingTimeService.getCurrentProcessingTime() + RETRY_DELAY,
- ts -> commitAndEmitCheckpoints());
+ private void emit(CheckpointCommittableManager<CommT> committableManager) {
+ int subtaskId = getRuntimeContext().getTaskInfo().getIndexOfThisSubtask();
+ int numberOfSubtasks = getRuntimeContext().getTaskInfo().getNumberOfParallelSubtasks();
Review Comment:
Nit: I know this wasn't introduced by this PR but why do we need to fetch the subtask id and number of tasks on every `emit` call?
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/connector/sink2/GlobalCommitterOperator.java:
##########
@@ -95,6 +94,7 @@
public class GlobalCommitterOperator<CommT, GlobalCommT> extends AbstractStreamOperator<Void>
implements OneInputStreamOperator<CommittableMessage<CommT>, Void> {
+ private static final int MAX_RETRIES = 10;
Review Comment:
IMO we should make this a Flink config specific to the sink and allow users to opt-out with the failed committable mechanism.
Currently the number is duplicated in committer and global committer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]
Posted by "AHeise (via GitHub)" <gi...@apache.org>.
AHeise commented on code in PR #25547:
URL: https://github.com/apache/flink/pull/25547#discussion_r1819084931
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableSummary.java:
##########
@@ -39,11 +39,21 @@ public class CommittableSummary<CommT> implements CommittableMessage<CommT> {
private final long checkpointId;
/** The number of committables coming from the given subtask in the particular checkpoint. */
private final int numberOfCommittables;
+
+ @Deprecated
/** The number of committables that have not been successfully committed. */
private final int numberOfPendingCommittables;
+
+ @Deprecated
/** The number of committables that are not retried and have been failed. */
private final int numberOfFailedCommittables;
Review Comment:
Good point. I probably should motivate that change in the commit message first. The short answer is: it doesn't work. Let's go to the long one.
So far, we increase this number on known issue and don't emit the respective committable. That means that the global committer would need to wait for all committables except the failed once and then commit. However, it always used to wait for all known committables running in an infinite loop.
The change of this PR only creates the summary of successful commits. Unknown errors cause a restart loop and known errors cause the committables to be dropped from the statistics. So the global committer waits for all committables of the summary and works now.
The alternative would be to still update the stastics as you propose and ignore the failed in the global committer. However, I wonder what the value of that is. If you'd like to keep it just to have less disruptions, I can revert the change and fix it.
However, the custom topologies that I have seen so far, also run into the same issue as the global committer (and now I think that the compactor has the same issues). I think that emitting the stats on the ignored committables ultimately just increases complexity without giving downstream operators any good handle whatsoever.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]
Posted by "fapaul (via GitHub)" <gi...@apache.org>.
fapaul commented on code in PR #25547:
URL: https://github.com/apache/flink/pull/25547#discussion_r1822429861
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperator.java:
##########
@@ -164,41 +165,37 @@ public void notifyCheckpointComplete(long checkpointId) throws Exception {
private void commitAndEmitCheckpoints() throws IOException, InterruptedException {
long completedCheckpointId = endInput ? EOI : lastCompletedCheckpointId;
- do {
- for (CheckpointCommittableManager<CommT> manager :
- committableCollector.getCheckpointCommittablesUpTo(completedCheckpointId)) {
- commitAndEmit(manager);
- }
- // !committableCollector.isFinished() indicates that we should retry
- // Retry should be done here if this is a final checkpoint (indicated by endInput)
- // WARN: this is an endless retry, may make the job stuck while finishing
- } while (!committableCollector.isFinished() && endInput);
-
- if (!committableCollector.isFinished()) {
- // if not endInput, we can schedule retrying later
- retryWithDelay();
+ for (CheckpointCommittableManager<CommT> checkpointManager :
+ committableCollector.getCheckpointCommittablesUpTo(completedCheckpointId)) {
+ // ensure that all committables of the first checkpoint are fully committed before
+ // attempting the next committable
+ commitAndEmit(checkpointManager);
+ committableCollector.remove(checkpointManager);
}
- committableCollector.compact();
}
private void commitAndEmit(CheckpointCommittableManager<CommT> committableManager)
throws IOException, InterruptedException {
- Collection<CommittableWithLineage<CommT>> committed = committableManager.commit(committer);
- if (emitDownstream && committableManager.isFinished()) {
- int subtaskId = getRuntimeContext().getTaskInfo().getIndexOfThisSubtask();
- int numberOfSubtasks = getRuntimeContext().getTaskInfo().getNumberOfParallelSubtasks();
- output.collect(
- new StreamRecord<>(committableManager.getSummary(subtaskId, numberOfSubtasks)));
- for (CommittableWithLineage<CommT> committable : committed) {
- output.collect(new StreamRecord<>(committable.withSubtaskId(subtaskId)));
- }
+ committableManager.commit(committer, MAX_RETRIES);
+ if (emitDownstream) {
+ emit(committableManager);
}
}
- private void retryWithDelay() {
- processingTimeService.registerTimer(
- processingTimeService.getCurrentProcessingTime() + RETRY_DELAY,
- ts -> commitAndEmitCheckpoints());
+ private void emit(CheckpointCommittableManager<CommT> committableManager) {
+ int subtaskId = getRuntimeContext().getTaskInfo().getIndexOfThisSubtask();
+ int numberOfSubtasks = getRuntimeContext().getTaskInfo().getNumberOfParallelSubtasks();
Review Comment:
Mostly should looked strange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]
Posted by "fapaul (via GitHub)" <gi...@apache.org>.
fapaul commented on code in PR #25547:
URL: https://github.com/apache/flink/pull/25547#discussion_r1827385788
##########
flink-core/src/main/java/org/apache/flink/configuration/SinkOptions.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.configuration;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import static org.apache.flink.configuration.ConfigOptions.key;
+
+/** Configuration options for sinks. */
+@PublicEvolving
+public class SinkOptions {
+ /**
+ * The number of retries on a committable (e.g., transaction) before Flink application fails and
+ * potentially restarts.
+ */
+ public static final ConfigOption<Integer> COMMITTER_RETRIES =
+ key("sink.committer.retries")
+ .intType()
+ .defaultValue(10)
+ .withDescription(
+ "The number of retries on a committable (e.g., transaction) before Flink application fails and potentially restarts.");
Review Comment:
Sounds much better 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]
Posted by "fapaul (via GitHub)" <gi...@apache.org>.
fapaul commented on code in PR #25547:
URL: https://github.com/apache/flink/pull/25547#discussion_r1822432325
##########
flink-core/src/main/java/org/apache/flink/configuration/SinkOptions.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.configuration;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import static org.apache.flink.configuration.ConfigOptions.key;
+
+/** Configuration options for sinks. */
+@PublicEvolving
+public class SinkOptions {
+ /**
+ * The number of retries on a committable (e.g., transaction) before Flink application fails and
+ * potentially restarts.
+ */
+ public static final ConfigOption<Integer> COMMITTER_RETRIES =
+ key("sink.committer.retries")
+ .intType()
+ .defaultValue(10)
+ .withDescription(
+ "The number of retries on a committable (e.g., transaction) before Flink application fails and potentially restarts.");
Review Comment:
Nit: Should we mention here that it applies to `CommitRequest#signalFailedWithUnknownReason` and not generic exceptions that are thrown during calling `commit` on the committer.
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/committables/CheckpointCommittableManager.java:
##########
@@ -69,8 +61,12 @@ public interface CheckpointCommittableManager<CommT> {
* checkpoint have been received.
*
* @param committer used to commit to the external system
- * @return successfully committed committables with meta information
+ * @param maxRetries
*/
- Collection<CommittableWithLineage<CommT>> commit(Committer<CommT> committer)
+ void commit(Committer<CommT> committer, int maxRetries)
throws IOException, InterruptedException;
+
+ Collection<CommT> getSuccessfulCommittables();
+
+ int getNumFailed();
Review Comment:
Please add doc strings to the method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]
Posted by "AHeise (via GitHub)" <gi...@apache.org>.
AHeise commented on code in PR #25547:
URL: https://github.com/apache/flink/pull/25547#discussion_r1820836505
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperator.java:
##########
@@ -164,41 +165,37 @@ public void notifyCheckpointComplete(long checkpointId) throws Exception {
private void commitAndEmitCheckpoints() throws IOException, InterruptedException {
long completedCheckpointId = endInput ? EOI : lastCompletedCheckpointId;
- do {
- for (CheckpointCommittableManager<CommT> manager :
- committableCollector.getCheckpointCommittablesUpTo(completedCheckpointId)) {
- commitAndEmit(manager);
- }
- // !committableCollector.isFinished() indicates that we should retry
- // Retry should be done here if this is a final checkpoint (indicated by endInput)
- // WARN: this is an endless retry, may make the job stuck while finishing
- } while (!committableCollector.isFinished() && endInput);
-
- if (!committableCollector.isFinished()) {
- // if not endInput, we can schedule retrying later
- retryWithDelay();
+ for (CheckpointCommittableManager<CommT> checkpointManager :
+ committableCollector.getCheckpointCommittablesUpTo(completedCheckpointId)) {
+ // ensure that all committables of the first checkpoint are fully committed before
+ // attempting the next committable
+ commitAndEmit(checkpointManager);
+ committableCollector.remove(checkpointManager);
}
- committableCollector.compact();
}
private void commitAndEmit(CheckpointCommittableManager<CommT> committableManager)
throws IOException, InterruptedException {
- Collection<CommittableWithLineage<CommT>> committed = committableManager.commit(committer);
- if (emitDownstream && committableManager.isFinished()) {
- int subtaskId = getRuntimeContext().getTaskInfo().getIndexOfThisSubtask();
- int numberOfSubtasks = getRuntimeContext().getTaskInfo().getNumberOfParallelSubtasks();
- output.collect(
- new StreamRecord<>(committableManager.getSummary(subtaskId, numberOfSubtasks)));
- for (CommittableWithLineage<CommT> committable : committed) {
- output.collect(new StreamRecord<>(committable.withSubtaskId(subtaskId)));
- }
+ committableManager.commit(committer, MAX_RETRIES);
+ if (emitDownstream) {
+ emit(committableManager);
}
}
- private void retryWithDelay() {
- processingTimeService.registerTimer(
- processingTimeService.getCurrentProcessingTime() + RETRY_DELAY,
- ts -> commitAndEmitCheckpoints());
+ private void emit(CheckpointCommittableManager<CommT> committableManager) {
+ int subtaskId = getRuntimeContext().getTaskInfo().getIndexOfThisSubtask();
+ int numberOfSubtasks = getRuntimeContext().getTaskInfo().getNumberOfParallelSubtasks();
Review Comment:
What's the concern here? Peformance? JVM should inline the call to pretty much result into a field access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]
Posted by "AHeise (via GitHub)" <gi...@apache.org>.
AHeise commented on PR #25547:
URL: https://github.com/apache/flink/pull/25547#issuecomment-2444290856
Reverted the deprecation of numFailed and added a config option for the retries. PTAL @fapaul
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]
Posted by "AHeise (via GitHub)" <gi...@apache.org>.
AHeise commented on code in PR #25547:
URL: https://github.com/apache/flink/pull/25547#discussion_r1827370992
##########
flink-core/src/main/java/org/apache/flink/configuration/SinkOptions.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.configuration;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import static org.apache.flink.configuration.ConfigOptions.key;
+
+/** Configuration options for sinks. */
+@PublicEvolving
+public class SinkOptions {
+ /**
+ * The number of retries on a committable (e.g., transaction) before Flink application fails and
+ * potentially restarts.
+ */
+ public static final ConfigOption<Integer> COMMITTER_RETRIES =
+ key("sink.committer.retries")
+ .intType()
+ .defaultValue(10)
+ .withDescription(
+ "The number of retries on a committable (e.g., transaction) before Flink application fails and potentially restarts.");
Review Comment:
A good point. I fear that giving too much details is confusing (which end user knows CommitRequest?).
I'd rephrase to
`The number of retries a Flink application attempts for committable operations (such as transactions) on retriable errors, as specified by the sink connector, before Flink fails and potentially restarts.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36455] Sinks retry synchronously [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25547:
URL: https://github.com/apache/flink/pull/25547#issuecomment-2422494183
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c4672fc5f56fc099f46520017755ebafaadcbd25",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c4672fc5f56fc099f46520017755ebafaadcbd25",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4672fc5f56fc099f46520017755ebafaadcbd25 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org