[jira] Commented: (PIG-553) EvalFunc.finish() not getting called

["Shravan Matthur Narayanamurthy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665074#action_12665074 ] 

Shravan Matthur Narayanamurthy commented on PIG-553:
----------------------------------------------------

I think the finish method in EvalFunc is just a remnant of our earlier code(prev trunk). I do not think we planned to include it because I don't see any infrastructure to call it. Though Chris's concern is only in local mode and it can be fixed temporarily by just calling a visitor that visits all the operators and if a POUserFunc is found calls its finish method. But what do we do for the MapRed case? Should we implement a similar behaviour in the close method? Do we need to support this kind of an operation for all operators? If so then should we also give a place holder for open()? 

> EvalFunc.finish() not getting called
> ------------------------------------
>
>                 Key: PIG-553
>                 URL: https://issues.apache.org/jira/browse/PIG-553
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>         Environment: "local" mode
>            Reporter: Christopher Olston
>            Assignee: Shravan Matthur Narayanamurthy
>
> My EvalFunc's finish() method doesn't seem to get invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.