[GitHub] [flink] tillrohrmann commented on a change in pull request #16915: [FLINK-9925][tests] Harden ClientTest by making handler shareable

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #16915:
URL: https://github.com/apache/flink/pull/16915#discussion_r693849351



##########
File path: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java
##########
@@ -881,4 +814,54 @@ protected void initChannel(SocketChannel ch) throws Exception {
     private InetSocketAddress getKvStateServerAddress(Channel serverChannel) {
         return (InetSocketAddress) serverChannel.localAddress();
     }
+
+    private static class ChannelDataCollectingHandler extends ChannelInboundHandlerAdapter {

Review comment:
       Because it is stateful and cannot be shared. Otherwise we might associate a message with a wrong `Channel`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org