You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/09 09:30:53 UTC
[GitHub] [netbeans] isarthur opened a new pull request #2434: Add support for static imports in code templates
isarthur opened a new pull request #2434:
URL: https://github.com/apache/netbeans/pull/2434
This PR is my attempt to add support for static imports in code templates. I've added an additional hint `staticImport` for the Java Code Template Processor. When processed by the processor, a static import declaration and static member identifier will be added to the source code. From the user's perspective, this will work something like this:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] isarthur commented on a change in pull request #2434: Add support for static imports in code templates
Posted by GitBox <gi...@apache.org>.
isarthur commented on a change in pull request #2434:
URL: https://github.com/apache/netbeans/pull/2434#discussion_r505261107
##########
File path: java/java.editor/nbproject/project.properties
##########
@@ -17,7 +17,7 @@
javadoc.title=Java Editor
-spec.version.base=2.78.0
+spec.version.base=2.79.0
Review comment:
Thanks @lkishalmi for the review. I'm not sure if this change is actually an API change, and if so, where this API change should be documented (there are no apichanges.xml and arch.xml files in the java/java.editor, all changes in the production code apply only to private methods)? Should I add the since tag to private methods or not increment the specification version at all?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #2434: Add support for static imports in code templates
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2434:
URL: https://github.com/apache/netbeans/pull/2434#discussion_r504049582
##########
File path: java/java.editor/nbproject/project.properties
##########
@@ -17,7 +17,7 @@
javadoc.title=Java Editor
-spec.version.base=2.78.0
+spec.version.base=2.79.0
Review comment:
What is the reason behind increasing the spec version? Are we changing something public in API/SPI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2434: Add support for static imports in code templates
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2434:
URL: https://github.com/apache/netbeans/pull/2434#issuecomment-714745263
@isarthur I'm sorry but I have force pushed your branch with the requested changes. If Travis agrees this one will go into 12.2-beta2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #2434: Add support for static imports in code templates
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2434:
URL: https://github.com/apache/netbeans/pull/2434
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists