[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6558: Upgrade zookeeper version to 3.5.8

[GitBox <gi...@apache.org>]

fx19880617 commented on a change in pull request #6558:
URL: https://github.com/apache/incubator-pinot/pull/6558#discussion_r574077770



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ZkStarter.java
##########
@@ -51,17 +52,18 @@ private ZookeeperInstance(PublicZooKeeperServerMain serverMain, String dataDirPa
   static class PublicZooKeeperServerMain extends ZooKeeperServerMain {
     @Override
     public void initializeAndRun(String[] args)
-        throws QuorumPeerConfig.ConfigException, IOException {
+        throws QuorumPeerConfig.ConfigException, IOException, AdminServer.AdminServerException {

Review comment:
       From ZooKeeperServerMain, it's added in zookeeper 3.5.x




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org