You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/01/04 16:00:00 UTC
[jira] [Commented] (DISPATCH-1901) Bad configuration self test does
not recognize all types of connection failure
[ https://issues.apache.org/jira/browse/DISPATCH-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258294#comment-17258294 ]
ASF subversion and git services commented on DISPATCH-1901:
-----------------------------------------------------------
Commit 27ae419b514ca962a37fa1cfedc7a67ae67447b3 in qpid-dispatch's branch refs/heads/master from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=27ae419 ]
DISPATCH-1901: Allow any proton:io reason failing connection to bad host name
The system_tests_bad_configuration test sets up a connector to a
host that is never reachable. The test expects the connection to fail.
On Linux proton normally returns 'Name or service not known'. On macOS
there is some other specific reason.
Another class of errors shows up when DNS is unavailable. On Linux the
reason is 'Temporary failure in name resolution'.
This patch stops looking for specific text from the proton:io error
messages. The test declares success when a qpid-dispatch log message
indicates a connection failure to the host in question.
This patch also removes nsswitch.conf binding from BWRAP as that
workaround is not necessary any more.
This closes #966
> Bad configuration self test does not recognize all types of connection failure
> ------------------------------------------------------------------------------
>
> Key: DISPATCH-1901
> URL: https://issues.apache.org/jira/browse/DISPATCH-1901
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.14.0
> Reporter: Charles E. Rolke
> Assignee: Charles E. Rolke
> Priority: Major
> Fix For: 1.15.0
>
>
> A qpid-dispatch self test tries to open a connector (outgoing connection) to an unresolvable address. [https://github.com/apache/qpid-dispatch/blob/0634a070aa6f902bf5b6f9537a5406e4cfc5a0d5/tests/system_tests_bad_configuration.py#L105]
> The expectation is that proton will return a certain proton:io error.
> {code:java}
> 2020-12-21 11:04:51.294685 -0500 SERVER (trace) [C1] Connecting to unresolvable.host.name:amqp (/home/chug/git/qpid-dispatch/src/server.c:1204)
> 2020-12-21 11:04:51.555518 -0500 SERVER (info) [C1] Connection to unresolvable.host.name:amqp failed: proton:io Name or service not known - connect to unresolvable.host.name:5672 (/home/chug/git/qpid-dispatch/src/server.c:1065)
> {code}
> In cases where DNS is unavailable proton returns a different error
> {code:java}
> 2020-12-21 15:53:46.738685 +0000 SERVER (trace) [C1] Connecting to unresolvable.host.name:amqp (/main/qpid-dispatch/src/server.c:1204)
> 2020-12-21 15:53:46.919237 +0000 SERVER (info) [C1] Connection to unresolvable.host.name:amqp failed: proton:io Temporary failure in name resolution - connect to unresolvable.host.name:5672 (/main/qpid-dispatch/src/server.c:1065)
> {code}
> It is unreasonable to expect the test environment to have DNS available just so that proton will return the expected IO error. The test should be adjusted so that any proton IO error is accepted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org