You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/09/08 21:58:53 UTC

[GitHub] [incubator-mxnet] anirudhacharya commented on a change in pull request #16122: Add fast implementation of LARS

anirudhacharya commented on a change in pull request #16122: Add fast implementation of LARS
URL: https://github.com/apache/incubator-mxnet/pull/16122#discussion_r322031022
 
 

 ##########
 File path: python/mxnet/optimizer/optimizer.py
 ##########
 @@ -781,6 +784,240 @@ def update(self, index, weight, grad, state):
         ftml_update(weight, grad, prev_d, prev_v, prev_z, out=weight,
                     lr=lr, wd=wd, **kwargs)
 
+@register
+class SGDwFastLARS(Optimizer):
 
 Review comment:
   is this different from LBSGD defined here - https://github.com/apache/incubator-mxnet/pull/16122/files#diff-0c893416e9e93fbd94dfaa9fa6c13d67R1022
   
   Currently LBSGD implementation is buggy, maybe this should replace that rather than create SGDwFastLARS?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services