You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/31 22:53:45 UTC
[GitHub] [incubator-superset] willbarrett commented on a change in pull
request #9017: [sip-15] Enabling SIP-15 by default
willbarrett commented on a change in pull request #9017: [sip-15] Enabling SIP-15 by default
URL: https://github.com/apache/incubator-superset/pull/9017#discussion_r373720627
##########
File path: superset/config.py
##########
@@ -748,7 +748,7 @@ class CeleryConfig: # pylint: disable=too-few-public-methods
#
# Note if no end date for the grace period is specified then the grace period is
# indefinite.
-SIP_15_ENABLED = False
+SIP_15_ENABLED = True
SIP_15_GRACE_PERIOD_END: Optional[date] = None # exclusive
Review comment:
I'm not speaking for @mistercrunch , but I would recommend the aggressive approach. That would provide us a milestone for when the flag can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org