You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/11 00:07:37 UTC
[GitHub] [incubator-superset] mihir174 edited a comment on pull request #11418: feat: Explore time picker enhancement
mihir174 edited a comment on pull request #11418:
URL: https://github.com/apache/incubator-superset/pull/11418#issuecomment-742879353
Hey @zhaoyongjie, thanks for this! Looks great. Here's some design input
Flow for the advanced time range (reflects button states and error messages) -
https://www.figma.com/file/JWaGztdhZS0kS5ruG7x9tB/Control-Panel?node-id=491%3A46097
Button states-
- validate is only active when an unvalidated change has been made
- apply is only active when changes have been validated and the time range is valid
Error Message -
Invalid Time Range: Start date cannot be after end date
Here's the error icon as an svg zip - [error_solid.svg.zip](https://github.com/apache/incubator-superset/files/5676320/error_solid.svg.zip)
The buttons should also use the Superset styles in storybook
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org