[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1311: HDDS-1946. CertificateClient should not persist keys/certs to ozone.m…

[GitBox <gi...@apache.org>]

xiaoyuyao commented on a change in pull request #1311: HDDS-1946. CertificateClient should not persist keys/certs to ozone.m…
URL: https://github.com/apache/hadoop/pull/1311#discussion_r318331343
 
 

 ##########
 File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
 ##########
 @@ -70,6 +70,7 @@
  */
 public class XceiverClientGrpc extends XceiverClientSpi {
   static final Logger LOG = LoggerFactory.getLogger(XceiverClientGrpc.class);
+  private static final String COMPONENT = "dn";
 
 Review comment:
   This may not work as expected. XCeiverClientGrpc is also use by ozone client to read key/file, using "dn" means we allows MR task running on datanode to use DN's key/cert for TLS? For client outside ozone cluster, they will not be able to connect TLS enabled GRPC endpoint. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org