[GitHub] [guacamole-server] necouchman commented on a change in pull request #317: GUACAMOLE-1186: Maintain the clipboard content of the remote server.

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #317:
URL: https://github.com/apache/guacamole-server/pull/317#discussion_r547298953



##########
File path: src/protocols/rdp/channels/cliprdr.c
##########
@@ -283,7 +283,8 @@ static UINT guac_rdp_cliprdr_format_list(CliprdrClientContext* cliprdr,
     if (guac_rdp_cliprdr_format_supported(format_list, CF_TEXT))
         return guac_rdp_cliprdr_send_format_data_request(cliprdr, CF_TEXT);
 
-    /* Ignore any unsupported data */
+    /* Suppose that any unsupported data is raw data (in this case, CF_RAW) */
+    guac_rdp_cliprdr_send_format_data_request(cliprdr, CF_RAW);

Review comment:
       Yes, but why reset the local clipboard? Why is resetting the local clipboard the solution to not erasing what's on the remote clipboard?

##########
File path: src/protocols/rdp/channels/cliprdr.c
##########
@@ -614,6 +619,11 @@ int guac_rdp_clipboard_end_handler(guac_user* user, guac_stream* stream) {
     if (clipboard == NULL)
         return 0;
 
+    /* Don't need to send it to the remote server, if the local clipboard is
+     * empty */
+    if (clipboard->clipboard->length == 0)
+        return 0;

Review comment:
       I'm not sure this logic is correct. What is someone wants to clear the clipboard and zero it out, removing all contents?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org