[GitHub] [pinot] timsants commented on a change in pull request #8358: New Pinot storage metrics for compressed tar.gz and table size w/o replicas

[GitBox <gi...@apache.org>]

timsants commented on a change in pull request #8358:
URL: https://github.com/apache/pinot/pull/8358#discussion_r827619487



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/upload/ZKOperator.java
##########
@@ -153,6 +153,10 @@ private void processExistingSegment(SegmentMetadata segmentMetadata, URI finalSe
     // previous segment upload did not finish properly and the parallel push protection is turned off
     existingSegmentZKMetadata.setSegmentUploadStartTime(-1);
 
+    if (currentSegmentLocation!= null) {

Review comment:
       For what cases is this going to be null?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org