You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "leizhiyuan (via GitHub)" <gi...@apache.org> on 2023/02/13 03:24:25 UTC
[GitHub] [rocketmq] leizhiyuan opened a new pull request, #6040: feat: uniform pop log file path
leizhiyuan opened a new pull request, #6040:
URL: https://github.com/apache/rocketmq/pull/6040
**Make sure set the target branch to `develop`**
## What is the purpose of the change
make pop log file same with other logs
## Brief changelog
uniform pop log file path
## Verifying this change
review the code
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] mxsm commented on pull request #6040: feat: uniform pop log file path
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on PR #6040:
URL: https://github.com/apache/rocketmq/pull/6040#issuecomment-1427521390
@leizhiyuan you can see this [document](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) that describes how a pr to link issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] leizhiyuan closed pull request #6040: [ISSUE #6046] feat: uniform pop log file path
Posted by "leizhiyuan (via GitHub)" <gi...@apache.org>.
leizhiyuan closed pull request #6040: [ISSUE #6046] feat: uniform pop log file path
URL: https://github.com/apache/rocketmq/pull/6040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] mxsm commented on pull request #6040: feat: uniform pop log file path
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on PR #6040:
URL: https://github.com/apache/rocketmq/pull/6040#issuecomment-1427432140
Hi @leizhiyuan you can create issue first. and link this pr to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] complone commented on pull request #6040: [ISSUE #6046] feat: uniform pop log file path
Posted by "complone (via GitHub)" <gi...@apache.org>.
complone commented on PR #6040:
URL: https://github.com/apache/rocketmq/pull/6040#issuecomment-1444951270
DefaultMQPushConsumerTest failed to run, please check the ci log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org